Merged
Conversation
4b1f911 to
7dff986
Compare
Signed-off-by: Jake Moshenko <[email protected]>
Signed-off-by: Jake Moshenko <[email protected]>
7dff986 to
12850c8
Compare
jzelinskie
reviewed
Sep 17, 2021
Comment on lines
+133
to
+139
| enum Operation { | ||
| OPERATION_UNSPECIFIED = 0; | ||
| OPERATION_MUST_NOT_MATCH = 1; | ||
| OPERATION_MUST_MATCH = 2; | ||
| } | ||
|
|
||
| Operation operation = 1; |
Member
There was a problem hiding this comment.
I am not convinced that the operation is necessary.
When would "must not match" be used? The precondition is basically supposed to be used to enable writes to function with compare-and-swap semantics, which only ever requires "must match" logic.
Member
There was a problem hiding this comment.
Joey's example of when you'd want "must not match": the first migration being ran for a system -- you'd want to assert that no relationships with any values for a migration would exist.
jzelinskie
approved these changes
Sep 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.