Skip to content

more specific relationship filters#4

Merged
jakedt merged 1 commit intomainfrom
better-filters
Sep 22, 2021
Merged

more specific relationship filters#4
jakedt merged 1 commit intomainfrom
better-filters

Conversation

@jakedt
Copy link
Copy Markdown
Member

@jakedt jakedt commented Sep 21, 2021

No description provided.

@jakedt jakedt force-pushed the better-filters branch 2 times, most recently from 452cb5c to 5f80710 Compare September 21, 2021 20:10
message SubjectFilter {
message RelationFilter {
string relation = 1 [ (validate.rules).string = {
pattern : "^[a-z][a-z0-9_]{2,62}[a-z0-9]$",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be able to be empty string

// relationship will return relationships that have exactly matching fields.
//
// resource_filter is required. All other fields are optional and if left
// object_type is required. All other fields are optional and if left
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resource_type

Copy link
Copy Markdown
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakedt jakedt merged commit 8d91f47 into main Sep 22, 2021
@jzelinskie jzelinskie deleted the better-filters branch September 22, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants