Add an error reason for caveat parameter type errors#42
Merged
josephschorr merged 1 commit intoauthzed:mainfrom Oct 18, 2022
Merged
Add an error reason for caveat parameter type errors#42josephschorr merged 1 commit intoauthzed:mainfrom
josephschorr merged 1 commit intoauthzed:mainfrom
Conversation
fc8f07f to
cf626db
Compare
vroldanbet
approved these changes
Oct 17, 2022
jzelinskie
reviewed
Oct 17, 2022
| // "expected_type": "int", | ||
| // } | ||
| // } | ||
| ERROR_REASON_CAVEAT_PARAMETER_TYPE_ERROR = 11; |
Member
There was a problem hiding this comment.
Does it make sense to have one error type for type errors and just include the additional details in the metadata?
Member
Author
There was a problem hiding this comment.
IMO, no. In this case: it is a type error with the usage of the caveat, rather than the definition of the schema. It will have different fields, and different semantics
Member
There was a problem hiding this comment.
Isn't this similar to the ERROR_REASON_INVALID_SUBJECT_TYPE above it which is also an error with the usage of a subject rather than the definition?
Member
Author
There was a problem hiding this comment.
No; the subject type is valid, but the context parameter is not; they are different errors with different metadata returned
jzelinskie
approved these changes
Oct 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will be used if the client sends a parameter value for a caveat that cannot be converted to the expected type