Merged
Conversation
the buf github action does not support configuring the tag to be pushed, so it always defaults to pushing the github SHA. This changes the action to push the tag to BSR with the ref_name instead of the commit SHA.
a7ba0b5 to
792264b
Compare
bison
approved these changes
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the buf github action does not support
configuring the tag to be pushed, so it
always defaults to pushing the github SHA.
This changes the action to push the tag
to BSR with the ref_name instead of the commit
SHA.
see https://github.com/authzed/api/actions/runs/8331581711/job/22798794304
Also see bufbuild/buf-push-action#20 (comment) for future changes on this topic, the buf team will be introducing some changes to help here