Conversation
8cdcb96 to
b17206b
Compare
karenc-bq
reviewed
Dec 4, 2025
aaron-congo
reviewed
Dec 12, 2025
aaron-congo
approved these changes
Dec 12, 2025
| return | ||
|
|
||
|
|
||
| class ConnectionHandler(Protocol): |
Contributor
There was a problem hiding this comment.
2 things:
- Curious, would it make sense for this to be outside of ReadWriteSplitting since it's a generic interface that both og rw splitting and srw uses
- ConnectionHandler seems like a generic name, but this is specific to read/write splitting. Maybe ReadWriteConnectionHandler or something might be a better name?
Contributor
Author
There was a problem hiding this comment.
- I'm open to moving it out if it feels appropriate. I was trying to follow what has been previously done, for example
connection_provider.pywhich has both the generic ConnectionProvider and also the DriverConnectionProvider - Agreed!
faviansamatha
approved these changes
Dec 17, 2025
22ce7b3 to
334f8b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.