fix(lambda-python): allowPublicSubnet and filesystem not supported#10022
Merged
mergify[bot] merged 5 commits intoaws:masterfrom Sep 1, 2020
adamdotdevin:10018
Merged
fix(lambda-python): allowPublicSubnet and filesystem not supported#10022mergify[bot] merged 5 commits intoaws:masterfrom adamdotdevin:10018
mergify[bot] merged 5 commits intoaws:masterfrom
adamdotdevin:10018
Conversation
Contributor
|
Shouldn't this PR move both |
Fixes #10018. #9468 added a flag (`allowPublicSubnet`) to `FunctionProps`, but `PythonFunction` and `NodejsFunction` props derive from `FunctionOptions`. This renders these derived function constructs unable to bypass the public subnet check that occurs in the base `Function` construct. We can resolve this issue by moving `allowPublicSubnet` to `FunctionOptions`. I also moved `filesystem` up to `FunctionOptions` while I was here.
Contributor
Author
|
Re-added the python integration test to pass the linter check. |
eladb
approved these changes
Sep 1, 2020
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
eladb
approved these changes
Sep 1, 2020
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10018.
Fixes #10027.
#9468 added a flag (
allowPublicSubnet) toFunctionProps, butPythonFunctionandNodejsFunctionprops derive fromFunctionOptions. This renders these derived function constructs unable to bypass the public subnet check that occurs in the baseFunctionconstruct. We can resolve this issue by movingallowPublicSubnettoFunctionOptions.I also moved
filesystemup toFunctionOptionswhile I was here.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license