Skip to content

chore!: drop Python 3.5 & 3.6 support#43

Merged
texastony merged 6 commits intoaws:masterfrom
texastony:chore-codeowners
Jan 24, 2023
Merged

chore!: drop Python 3.5 & 3.6 support#43
texastony merged 6 commits intoaws:masterfrom
texastony:chore-codeowners

Conversation

@texastony
Copy link
Copy Markdown
Contributor

@texastony texastony commented Jan 17, 2023

Issue #, if available: Broken CI/Drop Python 3.5 & 3.6

We should be able to approve First Time contributors to run CI actions, like in #41, but we cannot, possibly b/c we do not have a CODEOWNERS file.

Description of changes: add a code owner file.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ajewellamz
ajewellamz previously approved these changes Jan 17, 2023
@texastony texastony mentioned this pull request Jan 17, 2023
josecorella
josecorella previously approved these changes Jan 17, 2023
@texastony texastony reopened this Jan 17, 2023
@josecorella josecorella reopened this Jan 17, 2023
@texastony texastony dismissed stale reviews from josecorella and ajewellamz via 6eada3c January 23, 2023 23:39
@texastony texastony marked this pull request as draft January 24, 2023 00:36
@texastony texastony marked this pull request as ready for review January 24, 2023 00:38
@texastony
Copy link
Copy Markdown
Contributor Author

I will need to Squash and Merge this as a breaking change,
since we are dropping Python 3.5 & 3.6.

Also, I will need remove the Python 3.5 & 3.6 branch protections.
I have not dropped support for Python 2.7.

This library is very simple... it seems silly to drop Python 2.7 support until we can not test it in CI.

@texastony texastony changed the title chore: add CODEOWNERS chore!: drop Python 3.5 & 3.6 support Jan 24, 2023
@texastony
Copy link
Copy Markdown
Contributor Author

Removing Branch protection rules for 3.5 & 3.6.

@texastony texastony merged commit 3f03058 into aws:master Jan 24, 2023
@texastony texastony deleted the chore-codeowners branch January 24, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants