chore(build): use go1.14.x (#1164)

chenrui333 · web-flow · commit f6672cd902cf · 2020-07-20T17:16:42.000Z
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. Bump build go build runtime to latest release series, go1.14.x
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -2,7 +2,7 @@
 
 Thanks for your interest in contributing to the AWS Copilot CLI! 💖
 
-This document describes how to set up a development environment and submit your contributions.  
+This document describes how to set up a development environment and submit your contributions.
 Please read it over and let us know if it's not up-to-date (or, even better, submit a PR with your corrections 😉).
 
 - [Development setup](#development-setup)
@@ -20,7 +20,7 @@ Please read it over and let us know if it's not up-to-date (or, even better, sub
 
 ### Environment
 
-- Make sure you are using Go 1.13 (`go version`).
+- Make sure you are using Go 1.14 (`go version`).
 - Fork the repository.
 - Clone your forked repository locally.
 - We use Go Modules to manage dependencies, so you can develop outside of your $GOPATH.
@@ -37,17 +37,17 @@ From the repository root run:
 
 There are three different types of testing done on the AWS Copilot CLI.
 
-**Unit tests** makes up the majority of the testing and new code should include unit tests. 
-Ideally, these unit tests will be in the same package as the file they're testing and have full coverage (or as much is practical within a unit test). 
+**Unit tests** makes up the majority of the testing and new code should include unit tests.
+Ideally, these unit tests will be in the same package as the file they're testing and have full coverage (or as much is practical within a unit test).
 Unit tests shouldn't make any network calls.
 
-**Integration tests** are rarer and test the CLI's integration with remote services, such as the file system, CloudFormation, or SSM. 
+**Integration tests** are rarer and test the CLI's integration with remote services, such as the file system, CloudFormation, or SSM.
 Our integration tests ensure that we can call these remote services and get the results we expect.
 
-**End to End tests** run the CLI in a container and test the actual commands - including spinning and tearing down remote resources (like ECS clusters and VPCs). 
-These tests are the most comprehensive and run on both Windows and Linux build fleets. 
-Feel free to run these tests - but they require two AWS accounts to run in, so be mindful that resources will be created and destroyed. 
-You'll need three [named profiles](https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-profiles.html): `default`, `e2etestenv` and `e2eprodenv`. 
+**End to End tests** run the CLI in a container and test the actual commands - including spinning and tearing down remote resources (like ECS clusters and VPCs).
+These tests are the most comprehensive and run on both Windows and Linux build fleets.
+Feel free to run these tests - but they require two AWS accounts to run in, so be mindful that resources will be created and destroyed.
+You'll need three [named profiles](https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-profiles.html): `default`, `e2etestenv` and `e2eprodenv`.
 Each e2e profile needs to be configured for a different AWS account and a different region than the other e2e profiles.
 
 Below are the different commands which can be run in the root of the project directory.
@@ -65,17 +65,17 @@ Often times, it's helpful to generate mocks to make unit-testing easier and more
 
 ## Adding new dependencies
 
-In general, we discourage adding new dependencies to the AWS Copilot CLI. If there's a module you think the CLI could benefit from, first open a PR with your proposal. 
+In general, we discourage adding new dependencies to the AWS Copilot CLI. If there's a module you think the CLI could benefit from, first open a PR with your proposal.
 We'll evaluate the dependency and the use case and decide on the next steps. To evaluate if we need to add the dependency please take a look at [https://research.swtch.com/deps](https://research.swtch.com/deps).
 
 ## Where should I start?
 
-We're so excited you want to contribute to the CLI! We welcome all PRs and will try to get to them as soon as possible. 
+We're so excited you want to contribute to the CLI! We welcome all PRs and will try to get to them as soon as possible.
 The best place to start, though, is with filing an issue first. Filing an issue gives us some time to chat about the code you're keen on writing, and make sure that it's not already being worked on, or has already been discussed.
 
 You can also check out our [issues queue](https://github.com/aws/copilot-cli/issues) to see all the known issues - this is a really great place to start.
 
-If you want to get your feet wet, check out issues tagged with [good first issue](https://github.com/aws/copilot-cli/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22). 
+If you want to get your feet wet, check out issues tagged with [good first issue](https://github.com/aws/copilot-cli/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22).
 These issues are great for folks who are looking to get started, but not sure where to start 😁.
 
 ## Contributing code
diff --git a/Dockerfile b/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.13
+FROM golang:1.14
 # We need to have both nodejs and go to build the binaries.
 # We could use multi-stage builds but that would require significantly changing our Makefile.
 RUN apt-get update
diff --git a/buildspec-e2e.yml b/buildspec-e2e.yml
@@ -3,7 +3,7 @@ version: 0.2
 phases:
   install:
     runtime-versions:
-      golang: 1.13
+      golang: 1.14
       nodejs: 10
   build:
     commands:
diff --git a/buildspec.yml b/buildspec.yml
@@ -3,7 +3,7 @@ version: 0.2
 phases:
   install:
     runtime-versions:
-      golang: 1.13
+      golang: 1.14
   pre_build:
     commands:
       - echo "cd into $CODEBUILD_SRC_DIR"
diff --git a/buildspec_integ.yml b/buildspec_integ.yml
@@ -3,12 +3,11 @@ version: 0.2
 phases:
   install:
     runtime-versions:
-      golang: 1.13
+      golang: 1.14
   build:
     commands:
       - echo "Git commit hash for this revision:"
       - echo `git rev-parse HEAD` # Do not delete; for pipeline logging purposes
 artifacts:
-  files:      
-    - "**/*"            
-
+  files:
+    - "**/*"
diff --git a/e2e/addons/hello/Dockerfile b/e2e/addons/hello/Dockerfile
@@ -1,6 +1,6 @@
 # We specify the base image we need for our
 # go application
-FROM golang:1.13 AS builder
+FROM golang:1.14 AS builder
 # We create an /app directory within our
 # image that will hold our application source
 # files
@@ -30,4 +30,3 @@ RUN chmod +x ./api
 ENTRYPOINT ["./api"]
 # The service runs on port 80
 EXPOSE 80
-
diff --git a/e2e/addons/hello/go.mod b/e2e/addons/hello/go.mod
@@ -1,6 +1,6 @@
 module hello
 
-go 1.13
+go 1.14
 
 require (
 	github.com/aws/aws-sdk-go v1.29.22 // indirect
diff --git a/e2e/multi-svc-app/back-end/Dockerfile b/e2e/multi-svc-app/back-end/Dockerfile
@@ -1,6 +1,6 @@
 # We specify the base image we need for our
 # go application
-FROM golang:1.13 AS builder
+FROM golang:1.14 AS builder
 # We create an /app directory within our
 # image that will hold our application source
 # files
@@ -30,4 +30,3 @@ RUN chmod +x ./e2e-service
 ENTRYPOINT ["./e2e-service"]
 # The service runs on port 80
 EXPOSE 80
-
diff --git a/e2e/multi-svc-app/back-end/go.mod b/e2e/multi-svc-app/back-end/go.mod
@@ -1,5 +1,5 @@
 module github.com/aws/copilot-cli/e2e/multi-app-project/back-end
 
-go 1.13
+go 1.14
 
 require github.com/julienschmidt/httprouter v1.3.0 // indirect
diff --git a/e2e/multi-svc-app/front-end/Dockerfile b/e2e/multi-svc-app/front-end/Dockerfile
@@ -1,6 +1,6 @@
 # We specify the base image we need for our
 # go application
-FROM golang:1.13 AS builder
+FROM golang:1.14 AS builder
 # We create an /app directory within our
 # image that will hold our application source
 # files
@@ -30,4 +30,3 @@ RUN chmod +x ./e2e-service
 ENTRYPOINT ["./e2e-service"]
 # The service runs on port 80
 EXPOSE 80
-
diff --git a/e2e/multi-svc-app/front-end/go.mod b/e2e/multi-svc-app/front-end/go.mod
@@ -1,5 +1,5 @@
 module github.com/aws/copilot-cli/e2e/multi-app-project/front-end
 
-go 1.13
+go 1.14
 
 require github.com/julienschmidt/httprouter v1.3.0
diff --git a/e2e/multi-svc-app/www/Dockerfile b/e2e/multi-svc-app/www/Dockerfile
@@ -1,6 +1,6 @@
 # We specify the base image we need for our
 # go application
-FROM golang:1.13 AS builder
+FROM golang:1.14 AS builder
 # We create an /app directory within our
 # image that will hold our application source
 # files
@@ -30,4 +30,3 @@ RUN chmod +x ./www
 ENTRYPOINT ["./www"]
 # The service runs on port 80
 EXPOSE 80
-
diff --git a/e2e/multi-svc-app/www/go.mod b/e2e/multi-svc-app/www/go.mod
@@ -1,5 +1,5 @@
 module github.com/aws/copilot-cli/e2e/multi-app-project/www
 
-go 1.13
+go 1.14
 
 require github.com/julienschmidt/httprouter v1.3.0
diff --git a/go.mod b/go.mod
@@ -1,6 +1,6 @@
 module github.com/aws/copilot-cli
 
-go 1.13
+go 1.14
 
 require (
 	github.com/AlecAivazis/survey/v2 v2.0.8

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-FROM golang:1.13`
	`1`	`+FROM golang:1.14`
`2`	`2`	`# We need to have both nodejs and go to build the binaries.`
`3`	`3`	`# We could use multi-stage builds but that would require significantly changing our Makefile.`
`4`	`4`	`RUN apt-get update`
-Original file line number
+Diff line change
@@ @@ -1,5 +1,5 @@ @@
 module github.com/aws/copilot-cli/e2e/multi-app-project/back-end
 -go 1.13
 +go 1.14
 require github.com/julienschmidt/httprouter v1.3.0 // indirect