…980)

<!-- Provide summary of changes -->
Fix #979
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->
Add general sidecar support for svc deployment. With this change now users can configure sidecar in their manifest then do `svc deploy` to deploy their service with sidecar containers. 

Manual test pass (deployed a service with nginx as a sidecar container).

Next step is to add Firelens deployment and lastly add e2e tests for this feature.
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Adds execute method which renders user inputs into cloudformation template in addons dir.

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->
addresses #769 

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->
The ability to parse Healthcheck options from a user's dockerfile.

Also added, some of Moby buildkit packages for ease of parsing dockerfile. 

https://godoc.org/github.com/moby/buildkit/frontend/dockerfile/parser
https://godoc.org/github.com/moby/buildkit/frontend/dockerfile/instructions


<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->
Addresses #938

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.


Binary Size (added Mobykit parsers)
Before: 44.2 MB
After: 44.4 MB

<!-- Provide summary of changes -->
This PR adds the cloudformation template necessary to create DDB tables on behalf of customers in storage init. 

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->
Addresses #769 

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->
With #980, we fixed an issue which occurred when there were multiple dockerfiles present in the build directory. 

However, this may have broken our end to end tests, because the call to Docker was formatted as the following:

```sh
docker build -t <imageTag> path/to -f Dockerfile
```

This should be fine, but the end to end tests began to fail on Monday with the following output:
```bash
addons flow when deploying svc
  svc deploy should succeed
  /github.com/aws/amazon-ecs-cli-v2/e2e/addons/addons_test.go:145
unable to prepare context: unable to evaluate symlinks in Dockerfile path: lstat /github.com/aws/amazon-ecs-cli-v2/e2e/addons/Dockerfile: no such file or directory
Error: build Dockerfile at ./hello/Dockerfile with tag gallopinggurdey: building image: exit status 1
```
This indicates that although the Dockerfile path was set to `hello/Dockerfile`, Docker was looking for the file somewhere in the root directory of that path (.) and subsequently failing. 

This fix always sets the dockerfile path to be relative to the *root* of the docker build context, not the *leaf* of the build context. 

(previously we were parsing paths like `path/to/dockerfile` into `path/to` and `dockerfile`, assuming that the dockerfile would be searched for in `path/to`, not `path`. This was incorrect.)

The new behavior is to call:
```sh
docker build -t <imageTag> path/to -f path/to/dockerfile
```



<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->
Partially address #875. With this PR now we can deploy a Copilot service with Firelens as the log driver to deliver logs of the main container to destinations.

Users can config Firelens in two ways:

1. Set up configurations in the manifest (unable to sent to multiple destinations though).
2. Configure using fluentbit config file. Note that this requires users to build their own custom fluentbit image and specifying their config file path.

Additionally users might need to add permissions to task role if necessary. And they are able to add their own permissions by using Copilot addons feature. Any addons policy will be added to the task role.

This PR also adjusts `svc logs` to accommodate Firelens changes.
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->
Fixes #1008.

(I'm gonna rest in peace. Put the e2e test log on my grave and don't include any PR reviews other than LGTM)
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->
Fixes #1004.
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…xecution. (#1025)

This PR completes the implementation of `storage init`'s Execute() method. 
Notable changes:
* Adds S3 and DynamoDB structs to the addons package which behave similarly to those in the `manifest.LoadBalancedWebService` and `manifest.BackendService` structs. 
* Leverages the new AddonsWriter interface (with tiny modification) in `workspace` to enable template parsing for DDB and S3.
* Resolves several typos in the DDB template which would have rendered it undeployable

Unit tests forthcoming. 

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->
Quick fix to get rid of the unexpected period at the end of the log output when there's no service found in the app.
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…1035)

<!-- Provide summary of changes -->
This PR adds template functions to the storage resource CF templates. We now 
only need to specify a resource name to the DynamoDB and S3 types, and 
template functions StorageLogicalIDSafe and EnvVarName will properly construct
CF resource names and Env Vars. 

This PR also reorganizes and renames some common go template functions that 
previously lived in the "deploy/cloudformation/stack" package, moving them to the
"template" package.

Finally, it changes the implementation of ToSnakeCase to better match StringsWithUPPERCase
(now renders as "STRINGS_WITH_UPPER_CASE" instead of "STRINGS_WITH_U_P_P_E_R_CASE")
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->
This PR removes the notion of an Attribute from the UI of `copilot storage init`. 

Previously, customers could specify extra attributes via the `--att` flag which they could specify for use in Local Secondary Indices. This is problematic, however, because DynamoDB does not allow unused attributes to be written in the CF template and this would cause the addons stack deployment to fail. 

Removing "attribute" as a customer facing concept simplifies the user experience by only asking for "alternate sort keys/LSIs" and allows us to avoid complex validation issues which arise when extra attributes are specified. 

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This command removes the orphaned "Addons" group from the `copilot -h` help menu. 
<!-- Provide summary of changes -->

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This PR has two major changes:  1. add ask to task run;  2. add a required flag for task-family name, update validate and ask correspondingly 

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->
Related #702 

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Related: #918

<!-- Provide summary of changes -->

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->
Previously, we were converting timestamps into int64 types on Status structs. This change preserves the timestamp fields in time format, which makes timestamp fields in the JSONString output consistent with other JSON payloads (e.g. pipeline_show). It also simplifies the HumanString output logic.

This also includes a refactor of timestamps on Pipelines to use values rather than pointers.

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…alse (#1057)

<!-- Provide summary of changes -->
This change solves an issue where if a customer selected "No" when asked "Would you like to add any alternate sort keys to this DynamoDB table?", the `noLsi` option was not properly set and an erroneous line was injected into the CF template. 

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…age init (#1063)

<!-- Provide summary of changes -->
This PR changes `storage init` to use the WorkspaceSelector instead of the Application-wide ServiceSelector. 

Addresses #1054 
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->
Partially address #1069. Add service deployment info APIs to `deploy` pkg.
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->
Part of #1069. Fixes #1003.
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Add homebrew install directions

<!-- Provide summary of changes -->

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Update the docs with homebrew instructions. 
<!-- Provide summary of changes -->

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->
Last piece of #1069.
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->
This PR sets storage commands to visible and fixes a docstring.
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

We were missing an else bracket to our if statement
so LB Web Apps were always marked as not HTTPS because
the HTTPS Struct was being redefined.

Note, we need to add some tests for this 100%.


## Manual tests
This is for an app that uses HTTPS: 
`copilot svc package --output-dir infra`

Before:

```json
{
  "Parameters" : { 
    ...
    "HTTPSEnabled": "false"
  },
  "Tags": { 
    ...
  }
}
```

After:

```json
{
  "Parameters" : { 
   ...
    "HTTPSEnabled": "true"
  },
  "Tags": { 
    ...
  }
}
```
<!-- Provide summary of changes -->

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->
fixes #1148 
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Trying to fix the build issue encountered in the Homebrew/homebrew-core#57937
```
npm WARN [email protected] requires a peer of jest@>=24 <25 but none is installed. You must install peer dependencies yourself.

audited 823 packages in 9.037s

11 packages are looking for funding
  run `npm fund` for details
```

<!-- Provide summary of changes -->

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.


Bump build go build runtime to latest release series, go1.14.x

This PR modifies flags defined previously for task run, including:
1. fixing the variable type for `--command` flag and `--subnets` flag
2. fixing variable naming
3. fixing flag description: removing "Default to ..." at the end of the flag descriptions because cobra will automatically append a description of the default values at the end

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->
Fixes #1138. Enhance performance for `ListEnvironmentsDeployedTo` by running `GetResourcesByTags` in parallel.
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->
Add -race flag when building and testing to catch data race issues.
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This PR implements `Execute` for `task run`

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

current: $ copilot svc init --name frontend **--app-type** "Load Balanced Web Service" --dockerfile ./frontend/Dockerfile
suggest: $ copilot svc init --name frontend **--svc-type** "Load Balanced Web Service" --dockerfile ./frontend/Dockerfile

--app-type option does not exist. --svc-type is correct.

<!-- Provide summary of changes -->

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->
Remove -race from go build because it could increase memory usage by 5-10x and execution time by 2-20x. https://golang.org/doc/articles/race_detector.html#Runtime_Overheads
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

… role from cfn template (#1196)

This PR contains the following changes:
1. allowing user to specify a specific `execution-role` for `task run`
2. removing `DefaultTaskRole` from task's cfn template since it doesn't require a task role in order to run a task

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This change produces ARM binaries for Linux. We can't enable
the same for our darwin builds right now since go assumes that
darwin/arm64 is an iOS target:
golang/go#38485

This fixes #1058

<!-- Provide summary of changes -->

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->
Part of #1192.
1. Add `ListVpcSubnets` to list all subnets given a VPC ID.
2. Add pagination when calling `DescribeSubnets` so that we won't miss results in following pages.
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->
part of #1192.
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…issions (#1212)

This PR contains the following changes:
1. Update environment manager role's permission in support of `task run`
2. Update `task run` to use environment manager

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->
part of aws#1192.
<!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->
Part of #1192. Enable customized env resources by flags. UI change to env init is not included.
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->
Last part of #1192. Update `env init` UI to enable create customized env resources in an interactive way.
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->
This PR fixes `env init` by removing redundant prompt that asks users to select if they'd like to adjust/import/use default, even if users have already specified any of import/config flag set.
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…1265)

<!-- Provide summary of changes -->
This PR
1. Change the selection order in env init.
2. Update default flag in env init from `--no-customized-env` to `--default-config`

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->
Currently our task e2e test doesn't delete the task stack after running the task e2e test. And the task stack is very difficult to remove because the CFN Execution Role that used to manage the task stack is deleted when we delete copilot environment.  Also, the remaining task stacks piles up in our Copilot pipeline account.

This PR fixes this issue by removing task stack before we delete copilot app/env.
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This lowers the service discovery down from 1min to 10s. This value is how long a IP address is cached. While we wait for aws/containers-roadmap#343 to be resolved, we can lower the value to 10seconds. The longer this value is, the longer a service might fail to call another service due to a bad cache value.

fixes #1173

<!-- Provide summary of changes -->

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->
Previously, unit test mocks for `Ask()` returned values like "KeyName:S" when prompting for a partition key, sort key, or alternate sort key. This unit test updates the tests to match the actual behavior of the CLI. 

It also expands unit test coverage of the validate() method to ensure errors are correctly caught. 

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This PR adds e2e test for customized env resources.

<!-- Provide summary of changes -->

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<!-- Provide summary of changes -->
Move bash commands in e2e tests to `client` pkg so as to make e2e tests more declarative. Address #1264 (comment).
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Adds a new test suite exercising the docker build arg overrides. Deploys a service with a default env variable of "open caraway" and only succeeds if the manifest correctly overrides "open caraway" to "open sesame"

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.