Skip to content

fix(e2e): broken due to customized env resources#1258

Merged
mergify[bot] merged 2 commits intoaws:mainlinefrom
iamhopaul123:e2e/quick-fix
Aug 12, 2020
Merged

fix(e2e): broken due to customized env resources#1258
mergify[bot] merged 2 commits intoaws:mainlinefrom
iamhopaul123:e2e/quick-fix

Conversation

@iamhopaul123
Copy link
Copy Markdown
Contributor

@iamhopaul123 iamhopaul123 commented Aug 11, 2020

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@iamhopaul123 iamhopaul123 requested review from a team and kohidave and removed request for a team August 11, 2020 23:35
@iamhopaul123 iamhopaul123 requested a review from a team August 11, 2020 23:36
@iamhopaul123 iamhopaul123 added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Aug 11, 2020
@iamhopaul123
Copy link
Copy Markdown
Contributor Author

iamhopaul123 commented Aug 11, 2020

running e2e test now. will put down the label once it succeeds

efekarakus
efekarakus reviewed Aug 11, 2020
View reviewed changes
Comment thread e2e/internal/client/cli.go Outdated
@efekarakus
Copy link
Copy Markdown
Contributor

efekarakus commented Aug 11, 2020

We can do David's flag rename as a follow up

@iamhopaul123 iamhopaul123 removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Aug 12, 2020
@mergify mergify bot merged commit 54dee7a into aws:mainline Aug 12, 2020
thrau pushed a commit to localstack/copilot-cli-local that referenced this pull request Dec 9, 2022
@iamhopaul123 @thrau
fix(e2e): broken due to customized env resources (aws#1258)
91ddd8c 
<!-- Provide summary of changes -->

<!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kohidave kohidave Awaiting requested review from kohidave

2 more reviewers

@efekarakus efekarakus efekarakus approved these changes

@bvtujo bvtujo bvtujo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iamhopaul123 @efekarakus @bvtujo @amazon-ecs-cli-v2-pr-manager