chore(e2e): separate bash commands to client pkg#1297
Merged
mergify[bot] merged 4 commits intoaws:mainlinefrom Aug 19, 2020
Merged
chore(e2e): separate bash commands to client pkg#1297mergify[bot] merged 4 commits intoaws:mainlinefrom
mergify[bot] merged 4 commits intoaws:mainlinefrom
Conversation
bvtujo
approved these changes
Aug 19, 2020
Contributor
bvtujo
left a comment
There was a problem hiding this comment.
awesome work cleaning this up! super readable. Just a tiny nit.
19ba754 to
10c7345
Compare
efekarakus
reviewed
Aug 19, 2020
efekarakus
approved these changes
Aug 19, 2020
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
<!-- Provide summary of changes --> Move bash commands in e2e tests to `client` pkg so as to make e2e tests more declarative. Address aws#1264 (comment). <!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" --> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move bash commands in e2e tests to
clientpkg so as to make e2e tests more declarative. Address #1264 (comment).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.