fix(cli): unhide storage and storage init commands.#1147
fix(cli): unhide storage and storage init commands.#1147mergify[bot] merged 6 commits intoaws:masterfrom
Conversation
| github.com/spf13/afero v1.3.0 h1:Ysnmjh1Di8EaWaBv40CYR4IdaIsBc5996Gh1oZzCBKk= | ||
| github.com/spf13/afero v1.3.0/go.mod h1:5KUK8ByomD5Ti5Artl0RtHeI5pTF7MIDuXL3yY520V4= |
There was a problem hiding this comment.
ugh why these don't go away automatically. Thanks for removing them.
There was a problem hiding this comment.
I'm trying to get into the habit of running go mod tidy more often.
| github.com/onsi/ginkgo v1.14.0 | ||
| github.com/onsi/gomega v1.10.1 | ||
| github.com/pelletier/go-toml v1.8.0 // indirect | ||
| github.com/pkg/errors v0.9.1 |
There was a problem hiding this comment.
huh do you know why this was added?
There was a problem hiding this comment.
I'm honestly not sure; I ran go mod tidy and I don't quite know why this got picked up.
...
On further investigation it's added in the task pkg; looks like it got auto-added by goimports in #1145 when just "errors" would have worked.
There was a problem hiding this comment.
ooh @Louise15926 can you take a look at this, when working on the "task" pkg PR can we remove the dependency from the external errors and use "import errors" instead?
| Use: "init", | ||
| Short: "Creates a new storage table in an environment.", | ||
| Use: "init", | ||
| Short: "Creates a new storage resource in an environment.", |
There was a problem hiding this comment.
| Short: "Creates a new storage resource in an environment.", | |
| Short: "Creates a new storage config file in the addons directory.", |
There was a problem hiding this comment.
What do you think of this? I just want folks to know that it's not going to create a resource.
There was a problem hiding this comment.
ooh, yes, good point. Way more clear.
This PR sets storage commands to visible and fixes a docstring.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.