fix(storage): Remove "attribute" concept from UX#1037
Merged
mergify[bot] merged 5 commits intoaws:masterfrom Jun 22, 2020
Merged
fix(storage): Remove "attribute" concept from UX#1037mergify[bot] merged 5 commits intoaws:masterfrom
mergify[bot] merged 5 commits intoaws:masterfrom
Conversation
efekarakus
approved these changes
Jun 19, 2020
Contributor
efekarakus
left a comment
There was a problem hiding this comment.
LGTM just a log statement change
| } | ||
| if !moreAtt { | ||
| if len(o.lsiSorts) > 5 { | ||
| log.Infof("You may not specify more than 5 alternate sort keys. Continuing...") |
Contributor
There was a problem hiding this comment.
Should this be:
Suggested change
| log.Infof("You may not specify more than 5 alternate sort keys. Continuing...") | |
| log.Infoln("You may not specify more than 5 alternate sort keys. Continuing...") |
efekarakus
approved these changes
Jun 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the notion of an Attribute from the UI of
copilot storage init.Previously, customers could specify extra attributes via the
--attflag which they could specify for use in Local Secondary Indices. This is problematic, however, because DynamoDB does not allow unused attributes to be written in the CF template and this would cause the addons stack deployment to fail.Removing "attribute" as a customer facing concept simplifies the user experience by only asking for "alternate sort keys/LSIs" and allows us to avoid complex validation issues which arise when extra attributes are specified.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.