Skip to content

chore: add flag for task run execution role and remove default task role from cfn template#1196

Merged
mergify[bot] merged 5 commits intoaws:masterfrom
Louise15926:cli/roles
Jul 28, 2020
Merged

chore: add flag for task run execution role and remove default task role from cfn template#1196
mergify[bot] merged 5 commits intoaws:masterfrom
Louise15926:cli/roles

Conversation

@Louise15926
Copy link
Copy Markdown
Contributor

This PR contains the following changes:

  1. allowing user to specify a specific execution-role for task run
  2. removing DefaultTaskRole from task's cfn template since it doesn't require a task role in order to run a task

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Louise15926 Louise15926 requested a review from a team as a code owner July 27, 2020 19:40
@Louise15926 Louise15926 requested a review from kohidave July 27, 2020 19:40
@Louise15926 Louise15926 requested review from bvtujo, iamhopaul123 and piradeepk and removed request for kohidave July 27, 2020 19:41
Comment thread internal/pkg/cli/flag.go Outdated
Comment thread internal/pkg/cli/flag.go Outdated
Comment thread templates/task/cf.yml Outdated
Copy link
Copy Markdown
Contributor

@efekarakus efekarakus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 feel free to merge after the flag description changes

@efekarakus efekarakus added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Jul 28, 2020
Copy link
Copy Markdown
Contributor

@piradeepk piradeepk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! 💯

@Louise15926 Louise15926 removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Jul 28, 2020
@mergify mergify bot merged commit ba02b02 into aws:master Jul 28, 2020
@Louise15926 Louise15926 deleted the cli/roles branch August 5, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants