chore: add flag for task run execution role and remove default task role from cfn template#1196
Merged
mergify[bot] merged 5 commits intoaws:masterfrom Jul 28, 2020
Merged
Conversation
efekarakus
reviewed
Jul 27, 2020
efekarakus
approved these changes
Jul 28, 2020
Contributor
efekarakus
left a comment
There was a problem hiding this comment.
🚀 feel free to merge after the flag description changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
execution-rolefortask runDefaultTaskRolefrom task's cfn template since it doesn't require a task role in order to run a taskBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.