chore(storage): update unit test output to match input options#1284
Merged
mergify[bot] merged 4 commits intoaws:mainlinefrom Aug 17, 2020
Merged
chore(storage): update unit test output to match input options#1284mergify[bot] merged 4 commits intoaws:mainlinefrom
mergify[bot] merged 4 commits intoaws:mainlinefrom
Conversation
Contributor
Author
|
Investigating why this has merge conflicts. |
efekarakus
approved these changes
Aug 17, 2020
also rename variables to hopefully reduce such conflicts in the future
huanjani
approved these changes
Aug 17, 2020
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
) <!-- Provide summary of changes --> Previously, unit test mocks for `Ask()` returned values like "KeyName:S" when prompting for a partition key, sort key, or alternate sort key. This unit test updates the tests to match the actual behavior of the CLI. It also expands unit test coverage of the validate() method to ensure errors are correctly caught. <!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" --> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, unit test mocks for
Ask()returned values like "KeyName:S" when prompting for a partition key, sort key, or alternate sort key. This unit test updates the tests to match the actual behavior of the CLI.It also expands unit test coverage of the validate() method to ensure errors are correctly caught.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.