feat(storage): Add dynamoDB Cloudformation templates#993
Merged
mergify[bot] merged 8 commits intoaws:masterfrom Jun 4, 2020
Merged
feat(storage): Add dynamoDB Cloudformation templates#993mergify[bot] merged 8 commits intoaws:masterfrom
mergify[bot] merged 8 commits intoaws:masterfrom
Conversation
Contributor
Author
|
An example implementation is on the Go Playground here. The required data structures to execute this template look like this: type Attribute struct {
Name string
DataType string
}
type LocalSecondary struct {
Name string
PartitionKey string
SortKey string
}
type data struct {
TableResourceName string
TableName string
Attributes []Attribute
PartitionKey string
SortKey string
HasLSI bool
LSIs []LocalSecondary
} |
kohidave
reviewed
Jun 4, 2020
Contributor
kohidave
left a comment
There was a problem hiding this comment.
Looks great! Just a few suggestions!
| KeySchema: | ||
| - AttributeName: {{.PartitionKey}} | ||
| KeyType: HASH | ||
| - AttributeName: {{.SortKey}} |
Contributor
There was a problem hiding this comment.
I think we should add an if here, and only do the range key if someone provides it.
| - dynamodb:Query | ||
| - dynamodb:Scan | ||
| - dynamodb:BatchWrite* | ||
| - dynamodb:CreateTable |
Contributor
There was a problem hiding this comment.
Can we do Create* so that folks can CreateBackups too?
Co-authored-by: David Killmon <[email protected]>
kohidave
approved these changes
Jun 4, 2020
Contributor
kohidave
left a comment
There was a problem hiding this comment.
Approved once you add the retain!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the cloudformation template necessary to create DDB tables on behalf of customers in storage init.
Addresses #769
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.