chore: add e2e suite for extended svc configurations#1302
chore: add e2e suite for extended svc configurations#1302mergify[bot] merged 11 commits intoaws:mainlinefrom
Conversation
|
What do you think about modifying one of our existing tests like the I'm leaning towards creating a separate e2e test if it represents a different journey for the customer (like using a custom env instead of default env). Otherwise, let's try to shove the functionality to an existing test.
https://martinfowler.com/articles/practical-test-pyramid.html#End-to-endTests |
TODO: move this test into an existing suite
|
@efekarakus I think that's a good idea and will rework this test this afternoon. |
efekarakus
left a comment
There was a problem hiding this comment.
Looks really good to me! Let me know what you think of the comment below and then 
| Expect(err).NotTo(HaveOccurred(), "create destination manifest") | ||
| defer destFile.Close() | ||
|
|
||
| srcFile, err := os.Open("./front-end/manifest.yml") |
There was a problem hiding this comment.
I think if we move the manifest from "./front-end/manifest.yml" to "./copilot/front-end/manifest.yml" we can get rid of the code since "svc init" doesn't override the manifest anymore if one exists
| // in a response of "open sesame" | ||
| bodyBytes, err := ioutil.ReadAll(resp.Body) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(string(bodyBytes)).To(Equal("open sesame")) |
|
These pass locally. |
Adds a new test suite exercising the docker build arg overrides. Deploys a service with a default env variable of "open caraway" and only succeeds if the manifest correctly overrides "open caraway" to "open sesame" <!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" --> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Adds a new test suite exercising the docker build arg overrides. Deploys a service with a default env variable of "open caraway" and only succeeds if the manifest correctly overrides "open caraway" to "open sesame"
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.