chore(ec2): add ListVpcSubnets method and pagination#1210
Merged
mergify[bot] merged 2 commits intoaws:masterfrom Jul 31, 2020
Merged
chore(ec2): add ListVpcSubnets method and pagination#1210mergify[bot] merged 2 commits intoaws:masterfrom
mergify[bot] merged 2 commits intoaws:masterfrom
Conversation
kohidave
reviewed
Jul 30, 2020
Contributor
kohidave
left a comment
There was a problem hiding this comment.
Yay! We getting somewhere now!
d622a7d to
ccedec2
Compare
ccedec2 to
01f240b
Compare
kohidave
approved these changes
Jul 31, 2020
efekarakus
reviewed
Jul 31, 2020
| } | ||
|
|
||
| // ListVpcSubnets lists all subnets given a VPC ID. | ||
| func (c *EC2) ListVpcSubnets(vpcID string) (*Subnets, error) { |
Contributor
There was a problem hiding this comment.
@iamhopaul123 https://github.com/golang/go/wiki/CodeReviewComments#initialisms omggg
ListVPCSubnets
Comment on lines
+46
to
+47
| PublicSubnets []string | ||
| PrivateSubnets []string |
Contributor
There was a problem hiding this comment.
type Subnets struct {
Public []string
Private []string
}
Subnets.PublicSubnets is redundant :P
Contributor
Author
There was a problem hiding this comment.
i'll update it in the next one :P
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1192.
ListVpcSubnetsto list all subnets given a VPC ID.DescribeSubnetsso that we won't miss results in following pages.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.