Skip to content

chore(deps): fix ts-jest peer-dep issue with jest#1163

Merged
mergify[bot] merged 1 commit intoaws:masterfrom
chenrui333:ts-jest-peer-dep
Jul 20, 2020
Merged

chore(deps): fix ts-jest peer-dep issue with jest#1163
mergify[bot] merged 1 commit intoaws:masterfrom
chenrui333:ts-jest-peer-dep

Conversation

@chenrui333
Copy link
Copy Markdown
Contributor

@chenrui333 chenrui333 commented Jul 18, 2020

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Trying to fix the build issue encountered in the Homebrew/homebrew-core#57937

npm WARN [email protected] requires a peer of jest@>=24 <25 but none is installed. You must install peer dependencies yourself.

audited 823 packages in 9.037s

11 packages are looking for funding
  run `npm fund` for details

@chenrui333 chenrui333 requested a review from a team as a code owner July 18, 2020 21:49
@chenrui333 chenrui333 requested a review from kohidave July 18, 2020 21:49
efekarakus
efekarakus approved these changes Jul 20, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@efekarakus efekarakus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mergify mergify bot merged commit 3ebc845 into aws:master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kohidave kohidave Awaiting requested review from kohidave

2 more reviewers

@efekarakus efekarakus efekarakus approved these changes

@bvtujo bvtujo bvtujo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chenrui333 @efekarakus @bvtujo @amazon-ecs-cli-v2-pr-manager