feat: ARM64 build target for linux#1208
Merged
mergify[bot] merged 1 commit intoaws:masterfrom Jul 30, 2020
Merged
Conversation
efekarakus
reviewed
Jul 29, 2020
| @@ -46,6 +46,7 @@ compile-windows: | |||
|
|
|||
| compile-linux: | |||
| CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -ldflags "${LINKER_FLAGS} ${RELEASE_BUILD_LINKER_FLAGS}" -o ${DESTINATION}-amd64 ./cmd/copilot | |||
Contributor
There was a problem hiding this comment.
how much of a pain is it to update this one to -linux-amd64?
I think the buildspec needs to be updated as well
Contributor
Author
There was a problem hiding this comment.
oky doky. i kept around the old one as well, until we can update our pipeline.
Contributor
There was a problem hiding this comment.
This shouldn't require a pipeline update fortunately, since artifact releases are done by looping over the objects listed in the manifest file.
This change produces ARM binaries for Linux. We can't enable the same for our darwin builds right now since go assumes that darwin/arm64 is an iOS target: golang/go#38485 This fixes aws#1058
efekarakus
approved these changes
Jul 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change produces ARM binaries for Linux. We can't enable
the same for our darwin builds right now since go assumes that
darwin/arm64 is an iOS target:
golang/go#38485
This fixes #1058
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.