test(e2e): add e2e test for customized resources#1264
Merged
mergify[bot] merged 5 commits intoaws:mainlinefrom Aug 18, 2020
Merged
test(e2e): add e2e test for customized resources#1264mergify[bot] merged 5 commits intoaws:mainlinefrom
mergify[bot] merged 5 commits intoaws:mainlinefrom
Conversation
Contributor
Author
|
looks like we are doing a release tomorrow. i'll split up this pr and get env init changes out of this one. |
066f613 to
6298792
Compare
efekarakus
reviewed
Aug 13, 2020
5057be1 to
c419f81
Compare
44cda84 to
64f51d8
Compare
kohidave
reviewed
Aug 17, 2020
Comment on lines
+52
to
+62
| It("deploy vpc cloudformation stack", func() { | ||
| err := command.Run("aws", []string{"cloudformation", "create-stack", "--stack-name", | ||
| vpcStackName, "--template-body", vpcStackTemplatePath}) | ||
| Expect(err).NotTo(HaveOccurred(), "create vpc cloudformation stack") | ||
| err = command.Run("aws", []string{"cloudformation", "wait", "stack-create-complete", "--stack-name", vpcStackName}) | ||
| Expect(err).NotTo(HaveOccurred(), "vpc stack create complete") | ||
| }) |
Contributor
There was a problem hiding this comment.
Can we throw this into a BeforeAll?
Comment on lines
+60
to
+66
| var b bytes.Buffer | ||
| err := command.Run("bash", []string{"-c", fmt.Sprintf("aws cloudformation describe-stacks --stack-name %s | jq -r .Stacks[0].Outputs", vpcStackName)}, command.Stdout(&b)) | ||
| Expect(err).NotTo(HaveOccurred(), "describe vpc cloudformation stack") |
Contributor
There was a problem hiding this comment.
Maybe we can throw this into a aws.go file? (Like how we have the CLI one). The Output can be a VPC object or whatever - that way the tests stay really focused on the expected output.
| }) | ||
| }) | ||
|
|
||
| It("svc deploy should succeed to both environment", func() { |
Contributor
There was a problem hiding this comment.
Suggested change
| It("svc deploy should succeed to both environment", func() { | |
| It("svc deploy should succeed to both environments", func() { |
efekarakus
reviewed
Aug 18, 2020
| } | ||
| }) | ||
|
|
||
| It("env show should display info for test and prod envs", func() { |
Contributor
There was a problem hiding this comment.
Dumb question: Do we we care about any of the service workflows in this e2e test?
I wonder if instead we should have only this It and include --resources to the command to validate if the environment is created with the appropriate resource configurations?
Contributor
Author
There was a problem hiding this comment.
hmm i think it doesn't hurt to validate show and logs to make sure the svc we deploy is actually working as expected. But I'll add validation for --resources!
64f51d8 to
926a9b0
Compare
efekarakus
approved these changes
Aug 18, 2020
kohidave
approved these changes
Aug 18, 2020
mergify bot
pushed a commit
that referenced
this pull request
Aug 19, 2020
<!-- Provide summary of changes --> Move bash commands in e2e tests to `client` pkg so as to make e2e tests more declarative. Address #1264 (comment). <!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" --> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
This PR adds e2e test for customized env resources. <!-- Provide summary of changes --> <!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" --> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
<!-- Provide summary of changes --> Move bash commands in e2e tests to `client` pkg so as to make e2e tests more declarative. Address aws#1264 (comment). <!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" --> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds e2e test for customized env resources.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.