fix: HTTPS Params in "svc package" was always false#1150
Merged
mergify[bot] merged 1 commit intoaws:masterfrom Jul 16, 2020
Merged
fix: HTTPS Params in "svc package" was always false#1150mergify[bot] merged 1 commit intoaws:masterfrom
mergify[bot] merged 1 commit intoaws:masterfrom
Conversation
We were missing an else bracket to our if statement so LB Web Apps were always marked as not HTTPS because the HTTPS Struct was being redefined. Note, we need to add some tests for this 100%.
piradeepk
suggested changes
Jul 16, 2020
Contributor
piradeepk
left a comment
There was a problem hiding this comment.
lgtm! Can you add a unit test?
Contributor
Author
|
Yea - I'm trying to figure out how best to do this Hmmm. Will noodle on it - but we should try and get this change in before the next release given that it's kind of a nasty paper cut. But will continue to think about this one. |
efekarakus
approved these changes
Jul 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were missing an else bracket to our if statement
so LB Web Apps were always marked as not HTTPS because
the HTTPS Struct was being redefined.
Note, we need to add some tests for this 100%.
Manual tests
This is for an app that uses HTTPS:
copilot svc package --output-dir infraBefore:
{ "Parameters" : { ... "HTTPSEnabled": "false" }, "Tags": { ... } }After:
{ "Parameters" : { ... "HTTPSEnabled": "true" }, "Tags": { ... } }By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.