fix(cli): Correctly set NoLSI field when askDynamoLSIConfig returns false#1057
Merged
mergify[bot] merged 7 commits intoaws:masterfrom Jun 26, 2020
Merged
fix(cli): Correctly set NoLSI field when askDynamoLSIConfig returns false#1057mergify[bot] merged 7 commits intoaws:masterfrom
mergify[bot] merged 7 commits intoaws:masterfrom
Conversation
iamhopaul123
approved these changes
Jun 26, 2020
Contributor
iamhopaul123
left a comment
There was a problem hiding this comment.
ship it! Thanks for the quick turnaround.
efekarakus
reviewed
Jun 26, 2020
Comment on lines
+407
to
414
| if !moreLSI { | ||
| if len(o.lsiSorts) == 0 { | ||
| o.noLsi = true | ||
| } else { | ||
| o.noLsi = false | ||
| } | ||
| break | ||
| } |
Contributor
There was a problem hiding this comment.
can we have:
Suggested change
| if !moreLSI { | |
| if len(o.lsiSorts) == 0 { | |
| o.noLsi = true | |
| } else { | |
| o.noLsi = false | |
| } | |
| break | |
| } | |
| if !moreLSI { | |
| o.noLsi = len(o.lsiSorts) == 0 | |
| return nil | |
| } |
Contributor
There was a problem hiding this comment.
also can we update noLsi to noLSI
https://github.com/golang/go/wiki/CodeReviewComments#initialisms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change solves an issue where if a customer selected "No" when asked "Would you like to add any alternate sort keys to this DynamoDB table?", the
noLsioption was not properly set and an erroneous line was injected into the CF template.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.