test(describe): fix flaky "app status" tests due to passing time#918
Merged
mergify[bot] merged 1 commit intoaws:rename-commandsfrom May 13, 2020
efekarakus:cherry-pick-fix
Merged
test(describe): fix flaky "app status" tests due to passing time#918mergify[bot] merged 1 commit intoaws:rename-commandsfrom efekarakus:cherry-pick-fix
mergify[bot] merged 1 commit intoaws:rename-commandsfrom
efekarakus:cherry-pick-fix
Conversation
The humanize.Time function outputs time in human friendly ways (ex: "1 day ago"). Our test cases were expecting the string "1 month ago", but a few hours ago the output from humanize.Time changed to "2 months ago". This change hard-codes time.Now for the test, so that humanize.Time always returns the same value. We also moved the test from "cli/app_status_test.go" to "describe/status_test.go".
kohidave
approved these changes
May 13, 2020
iamhopaul123
approved these changes
May 13, 2020
SoManyHs
added a commit
to SoManyHs/copilot-cli
that referenced
this pull request
Jun 24, 2020
SoManyHs
added a commit
to SoManyHs/copilot-cli
that referenced
this pull request
Jun 24, 2020
SoManyHs
added a commit
to SoManyHs/copilot-cli
that referenced
this pull request
Jun 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks the fix #917 to the
rename-commandsbranch.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.