feat(stack): add general sidecar deployment support#978
Merged
mergify[bot] merged 6 commits intoaws:masterfrom Jun 2, 2020
Merged
feat(stack): add general sidecar deployment support#978mergify[bot] merged 6 commits intoaws:masterfrom
mergify[bot] merged 6 commits intoaws:masterfrom
Conversation
Contributor
Author
|
Example manifest file to deploy a service with nginx as a sidecar container (traffic will be routed to nginx): # The manifest for the "app" service.
# Read the full specification for the "Load Balanced Web Service" type at:
# https://github.com/aws/amazon-ecs-cli-v2/wiki/Manifests#load-balanced-web-svc
# Your service name will be used in naming your resources like log groups, ECS services, etc.
name: app
# The "architecture" of the service you're running.
type: Load Balanced Web Service
image:
# Path to your service's Dockerfile.
build: app/Dockerfile
# Port exposed through your container to route traffic to it.
port: 3000
http:
# Requests to this path will be forwarded to your service.
# To match all requests you can use the "/" path.
path: 'api'
# You can specify a custom health check path. The default is "/"
healthcheck: '/api/health-check'
targetContainer: 'nginx'
# Number of CPU units for the task.
cpu: 256
# Amount of memory in MiB used by the task.
memory: 512
# Number of tasks that should be running in your service.
count: 1
sidecars:
nginx:
port: 80
image: 403971813171.dkr.ecr.us-west-2.amazonaws.com/reverse-proxy:revision_1 # Image URL for sidecar container. Local images and images in the Docker Hub registry and ECR repository are supported.
# credentialParameter: # ARN of the secret containing the private repository credentials.
# Optional fields for more advanced use-cases.
#
#variables: # Pass environment variables as key value pairs.
# LOG_LEVEL: info
#
#secrets: # Pass secrets from AWS Systems Manager (SSM) Parameter Store.
# GITHUB_TOKEN: GITHUB_TOKEN # The key is the name of the environment variable, the value is the name of the SSM parameter.
# You can override any of the values defined above by environment.
#environments:
# test:
# count: 2 # Number of tasks to run for the "test" environment. |
6e29242 to
b688d89
Compare
kohidave
reviewed
Jun 1, 2020
kohidave
reviewed
Jun 1, 2020
Contributor
kohidave
left a comment
There was a problem hiding this comment.
This looks awesome. Just a small suggestion.
b688d89 to
08778a4
Compare
efekarakus
reviewed
Jun 1, 2020
efekarakus
approved these changes
Jun 2, 2020
kohidave
approved these changes
Jun 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add general sidecar support for svc deployment. With this change now users can configure sidecar in their manifest then do
svc deployto deploy their service with sidecar containers.Manual test pass (deployed a service with nginx as a sidecar container).
Next step is to add Firelens deployment and lastly add e2e tests for this feature.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.