Skip to content

chore: adds queue uri json generation#2667

Merged
mergify[bot] merged 6 commits intoaws:mainlinefrom
xar-tol:xar-tol/adds-queue-uri-json
Jul 29, 2021
Merged

chore: adds queue uri json generation#2667
mergify[bot] merged 6 commits intoaws:mainlinefrom
xar-tol:xar-tol/adds-queue-uri-json

Conversation

@xar-tol
Copy link
Copy Markdown
Contributor

@xar-tol xar-tol commented Jul 27, 2021

Adds generation of COPILOT_QUEUE_URIS with worker services.

Addresses #2550

@xar-tol xar-tol requested a review from a team as a code owner July 27, 2021 22:33
@xar-tol xar-tol requested review from Lou1415926 and removed request for a team July 27, 2021 22:33
*[]TopicSubscription -> []*TopicSubscription
Copy link
Copy Markdown
Contributor

@Lou1415926 Lou1415926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! This would be so helpful to users!

Comment thread templates/workloads/partials/cf/envvars.yml Outdated
adjusts to logicalIDSafe due to the way vars work
@xar-tol xar-tol requested a review from Lou1415926 July 28, 2021 17:50
Copy link
Copy Markdown
Contributor

@Lou1415926 Lou1415926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just two more nits 🙇🏼‍♀️

Comment thread templates/workloads/partials/cf/envvars.yml Outdated
Comment thread internal/pkg/template/template_functions.go Outdated
Comment thread internal/pkg/template/template_functions.go Outdated
@xar-tol xar-tol requested a review from Lou1415926 July 29, 2021 18:38
@mergify mergify bot merged commit 8fb57ac into aws:mainline Jul 29, 2021
@xar-tol xar-tol deleted the xar-tol/adds-queue-uri-json branch July 29, 2021 18:51
xar-tol added a commit to xar-tol/copilot-cli that referenced this pull request Aug 5, 2021
Adds generation of COPILOT_QUEUE_URIS with worker services.

Addresses aws#2550
thrau pushed a commit to localstack/copilot-cli-local that referenced this pull request Dec 9, 2022
Adds generation of COPILOT_QUEUE_URIS with worker services.

Addresses aws#2550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants