Conversation
CHANGELOG.md
Outdated
|
|
||
| ## [1.5.0] - 2021-03-30 | ||
|
|
||
| * **Tracing**: Removed deprecated attributes on `Tracing` annotation. If you are still using `captureResponse` and `captureError` |
There was a problem hiding this comment.
Isn't that a major update?
What's the cost in keeping both but leaving only one documented?
There was a problem hiding this comment.
That's how we deprecated it initially by removing its reference from our docs. So docs don't have these attributes referenced. It won't lead to any surprises functionally, since this will lead to a compile time error for users.
Cost of keeping deprecated attribute forever is basically technical debt.
|
Forever is a long time. you can cut a major release :)
If all of you are fine with the decision (I wouldn’t), then please make
sure this is called out in the release notes too
…On Tue, 30 Mar 2021 at 12:57, Pankaj Agrawal ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In CHANGELOG.md
<#345 (comment)>
:
> @@ -8,8 +8,22 @@ This project follows [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) fo
## [Unreleased]
+## [1.5.0] - 2021-03-30
+
+* **Tracing**: Removed deprecated attributes on `Tracing` annotation. If you are still using `captureResponse` and `captureError`
That's how we deprecated it initially by removing its reference from our
docs. So docs don't have these attributes referenced. It won't lead to any
surprises functionally, since this will lead to a compile time error for
users.
Cost of keeping deprecated attribute forever is basically technical debt.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#345 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBDKBBQDV3DWBQ7N7M3TGGVCBANCNFSM42BYLYRA>
.
|
Its no problem to cut a major release as well. Or maybe we can wait with the removal change until we really need to make a major release. Thoughts @msailes ? |
|
If that helps, for Python at least, we’re gonna start publishing our list
of tech debts we want to cut in 2.0.
I’ll ping once it’s public hopefully next week
On Tue, 30 Mar 2021 at 13:08, Pankaj Agrawal ***@***.***>
wrote:
… Forever is a long time. you can cut a major release :) If all of you are
fine with the decision (I wouldn’t), then please make sure this is called
out in the release notes too
… <#m_2236942094368262142_>
On Tue, 30 Mar 2021 at 12:57, Pankaj Agrawal *@*.*> wrote: @.** commented
on this pull request. ------------------------------ In CHANGELOG.md <#345
(comment)
<#345 (comment)>>
: > @@ -8,8 +8,22 @@ This project follows Keep a Changelog
<https://keepachangelog.com/en/1.0.0/> fo ## [Unreleased] +## [1.5.0] -
2021-03-30 + +* *Tracing*: Removed deprecated attributes on Tracing
annotation. If you are still using captureResponse and captureError
That's how we deprecated it initially by removing its reference from our
docs. So docs don't have these attributes referenced. It won't lead to any
surprises functionally, since this will lead to a compile time error for
users. Cost of keeping deprecated attribute forever is basically technical
debt. — You are receiving this because you commented. Reply to this email
directly, view it on GitHub <#345 (comment)
<#345 (comment)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZPQBDKBBQDV3DWBQ7N7M3TGGVCBANCNFSM42BYLYRA
.
Its no problem to cut a major release as well. Or maybe we can wait with
the removal change until we really need to make a major release. Thoughts
@msailes <https://github.com/msailes> ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#345 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBAHSVIXRSULZ3ISNJ3TGGWL5ANCNFSM42BYLYRA>
.
|
I am thinking maybe that's best way to solve it. Which means we can target more deprecated features as part of a single major release rather than bumping major release each time we remove a deperecated feature. |
4ec679a to
2673374
Compare
2673374 to
2df2579
Compare
|
@heitorlessa / @msailes Looks better? |
heitorlessa
left a comment
There was a problem hiding this comment.
Thanks a lot for taking breaking changes into account. I'm sure customers will appreciate that.
Issue #, if available:
Description of changes:
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.