fix(api_gateway): allow whitespace in routes' path parameter#1099
Merged
heitorlessa merged 3 commits intoaws-powertools:developfrom Apr 8, 2022
sthuber90:fix-1098
Merged
fix(api_gateway): allow whitespace in routes' path parameter#1099heitorlessa merged 3 commits intoaws-powertools:developfrom sthuber90:fix-1098
heitorlessa merged 3 commits intoaws-powertools:developfrom
sthuber90:fix-1098
Conversation
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
Codecov Report
@@ Coverage Diff @@
## develop #1099 +/- ##
========================================
Coverage 99.96% 99.96%
========================================
Files 119 119
Lines 5378 5378
Branches 613 613
========================================
Hits 5376 5376
Partials 2 2
Continue to review full report at Codecov.
|
Contributor
|
@sthuber90 Mind creating a separate test out the tests? So there's a separate test for whitespace checks? Want to make sure that the tests are easy to spot if we get a regression in the future |
Contributor
Author
|
Sure, will do |
heitorlessa
reviewed
Apr 8, 2022
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
heitorlessa
added a commit
to heitorlessa/aws-lambda-powertools-python
that referenced
this pull request
Apr 8, 2022
…ertools#1099) Co-authored-by: Heitor Lessa <[email protected]>
heitorlessa
added a commit
to heitorlessa/aws-lambda-powertools-python
that referenced
this pull request
Apr 8, 2022
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: fix(api_gateway): allow whitespace in routes' path parameter (aws-powertools#1099)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: #1098
Summary
Changes
Updated the
_UNSAFE_URIconstant to support whitespace in path parameterUser experience
User facing nothing changed
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.