Skip to content

feat(event_source): add support for dynamic partitions in the Api Gateway Authorizer event#2176

Merged
leandrodamascena merged 3 commits intoaws-powertools:developfrom
leif-ye:develop
Apr 28, 2023
Merged

feat(event_source): add support for dynamic partitions in the Api Gateway Authorizer event#2176
leandrodamascena merged 3 commits intoaws-powertools:developfrom
leif-ye:develop

Conversation

@leif-ye
Copy link
Copy Markdown
Contributor

@leif-ye leif-ye commented Apr 28, 2023 •
edited by leandrodamascena
Loading

CN partition adaption

Issue number: #2177

Summary

CN partition adaption

Changes

Change partition hard code

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leif-ye
Update api_gateway_authorizer_event.py
daec4a0 
CN partition adaption

Signed-off-by: leif ye <[email protected]>
@leif-ye leif-ye requested a review from a team as a code owner April 28, 2023 11:24
@leif-ye leif-ye requested review from heitorlessa and removed request for a team April 28, 2023 11:24
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg bot commented Apr 28, 2023

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our AWS Lambda Powertools Discord: Invite link

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 28, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 28, 2023

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

@github-actions github-actions bot added do-not-merge need-issue PRs that are missing related issues labels Apr 28, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 28, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d4607f3) 97.46% compared to head (40d5edc) 97.46%.

❗ Current head 40d5edc differs from pull request most recent head 26f96bb. Consider uploading reports for the commit 26f96bb to get more accurate results

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #2176   +/-   ##
========================================
  Coverage    97.46%   97.46%           
========================================
  Files          147      147           
  Lines         6875     6876    +1     
  Branches       505      505           
========================================
+ Hits          6701     6702    +1     
  Misses         137      137           
  Partials        37       37
Impacted Files Coverage Δ
...ities/data_classes/api_gateway_authorizer_event.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leandrodamascena
Copy link
Copy Markdown
Contributor

leandrodamascena commented Apr 28, 2023 •
edited
Loading

Hello @leif-ye! Thanks for submitting this PR to add CN partition support for this event source. Part of our automation failed because according to our contributing guide, the PR title must follow the conventional semantic title and every PR must also have an issue.

But don't worry if you can't fix these minor problems, I can do this when reviewing this PR.

I hope you have a great day.

@leandrodamascena leandrodamascena changed the title Update api_gateway_authorizer_event.py feat(event_source): add support to China and US Gov partitions in Api Gateway Authorizer event Apr 28, 2023
@github-actions github-actions bot added the feature New feature or functionality label Apr 28, 2023
@leandrodamascena leandrodamascena removed do-not-merge need-issue PRs that are missing related issues labels Apr 28, 2023
@leandrodamascena leandrodamascena requested review from leandrodamascena and removed request for heitorlessa April 28, 2023 15:32
leandrodamascena
leandrodamascena approved these changes Apr 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @leif-ye!
LGTM!

@leandrodamascena leandrodamascena changed the title feat(event_source): add support to China and US Gov partitions in Api Gateway Authorizer event feat(event_source): add support for dynamic partitions in the Api Gateway Authorizer event Apr 28, 2023
@leandrodamascena leandrodamascena merged commit 62fa81f into aws-powertools:develop Apr 28, 2023
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg bot commented Apr 28, 2023

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

@leandrodamascena leandrodamascena linked an issue Apr 28, 2023 that may be closed by this pull request
Feature request: add support to China and US Gov partitions in Api Gateway Authorizer event #2177
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandrodamascena leandrodamascena leandrodamascena approved these changes

Assignees

No one assigned

Labels

feature New feature or functionality size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature request: add support to China and US Gov partitions in Api Gateway Authorizer event

3 participants

@leif-ye @codecov-commenter @leandrodamascena