Conversation
LeaseManager was creating an empty leases map on startup, causing KeepAlive/TimeToLive to fail and expired leases to never be cleaned up after a server restart. Add LoadLeases() to hydrate the in-memory map from the store and initialize leaseIDCounter to prevent ID collisions.
- Remove unused nodeID, leaseIDCounter fields and counter recovery logic from LeaseManager (replaced by idutil.Generator upstream) - Fix comment mismatch: NewLeaseManagerWithNodeID → NewLeaseManagerWithMemberID - Update test constructor to match renamed function signature - Remove TestLeaseManager_LoadLeases_CounterInit (references deleted GenerateLeaseID) - Fix test imports: metaStore/api/http → metaStore/internal/http (package relocated)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: recover etcd leases after server restart