Skip to content

Added Left Click Mine Functionality#156

Merged
mat-1 merged 5 commits intoazalea-rs:1.20.6from
AS1100K:feature/1.20.6-auto-mine
Jul 22, 2024
Merged

Added Left Click Mine Functionality#156
mat-1 merged 5 commits intoazalea-rs:1.20.6from
AS1100K:feature/1.20.6-auto-mine

Conversation

@AS1100K
Copy link
Copy Markdown
Contributor

@AS1100K AS1100K commented Jun 17, 2024

What this PR does?

This PR, will introduce a function in azalea::Client i.e. left_click_mine, once it is enabled it will make the bot mine the blocks it is looking at if it is within it's range In simpler words, it is a simple left-click implementation for mining blocks.

Why this was added?

Although, it is quite basic functionality which could be used either for digging tunnels, mining stones in stone generator, etc. But I thought having it out of the box supported by azalea would be great, that's why I opened this PR.

Why this PR was not opened on the main branch of azalea?

The main branch currently, supports Minecraft version 1.21 and introduces changes in azalea-client/interact.rs which interferes with left_click_mine. This issue makes left_click_mine not work in 1.21. But I am working on a fix, and will soon open a PR to the main branch.

@imeesa
Copy link
Copy Markdown

imeesa commented Jun 18, 2024

lgtm, even though I have no permissions to say that

Comment thread azalea-client/src/mining.rs Outdated
Comment thread azalea-client/src/mining.rs Outdated
Comment thread azalea-client/src/mining.rs Outdated
@AS1100K AS1100K changed the title Added Auto Mine Functionality Added Left Click Mine Functionality Jul 20, 2024
@AS1100K AS1100K requested a review from mat-1 July 20, 2024 09:51
@AS1100K
Copy link
Copy Markdown
Contributor Author

AS1100K commented Jul 20, 2024

Should I also open this PR on main branch. Currently the error AlreadyPresentError is thrown but I think this has nothing to do with LeftClickMine.

@mat-1
Copy link
Copy Markdown
Collaborator

mat-1 commented Jul 20, 2024

Should I also open this PR on main branch.

Yeah, I forgot that this PR isn't targeted at the main branch, I'd appreciate that.

Currently the error AlreadyPresentError is thrown but I think this has nothing to do with LeftClickMine.

Wdym? Your branch and the main branch both work fine for me (at least when running the testbot example). What's your code that triggers that error?

@AS1100K
Copy link
Copy Markdown
Contributor Author

AS1100K commented Jul 20, 2024

Yeah, I forgot that this PR isn't targeted at the main branch, I'd appreciate that.

I have opened a PR #168 on the main branch.

@mat-1 mat-1 merged commit f35ba02 into azalea-rs:1.20.6 Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants