Conversation
|
Is the intent to merge this into the dev branch for the upcoming release or should we treat this as a mid-cycle housekeeping task and merge directly into main? Regardless, I think the current PR is merging the current dev branch as well, so I think you want to switch the target branch. Regarding the text in the README, I think it looks good. We can open an issue regarding the SDK/policy edits for this process moving forward. |
|
@kylegodbey Good catch, changed base to develop. |
|
I have reviewed the changes. I think this is a good fix to the issue of what to do about the ROSE situation. I suggest one change to the English: "Also included are packages developed by the the BAND Framework team but are no longer maintained"->either "Also included are packages that were developed by the the BAND Framework team but are no longer maintained:" or "Also included are packages developed by the the BAND Framework team that are no longer maintained:" We should have a general discussion about whether to change the SDK so it incorporates the possibility of sunsetted software. |
|
Since no one has expressed opposition and Kyle G approves, I'm going to go ahead and merge the PR in rose, and update the links here to point to the main branch of the repo which will reflect the updated readme. I'll also implement Daniel's suggestion. |
|
It's not clear to me why this test is failing. @wildsm any ideas? Once that's fixed, this should be good to merge. Error log from github actions: |
|
The action is failing due to failures to follow certain links such as I believe that However, rerunning the action resulted in the same failure. Investigating. |
|
The action failure and a possible solution are being documented in Issue #205. |
Fix broken URL checker action
|
Action failure is now fixed in this branch and actions are passing again. I'll review soon. |
Per discussion yesterday, this PR specifies in the various readmes that rose is no longer maintained.
There is a corresponding PR into the rose repo that adds a statement to the readme there: bandframework/rose#84
If no one on the rose team has a problem with this, I will first merge that, then update the links on this branch to point to the rose repo with this new message. Then this can be pulled in.
I will also add, this is the first time we are "sun-setting" a piece of software, but, given the fact that the nature of our work deals in testing ideas that (despite our best efforts) are not guaranteed to be successful in practice, this likely will not be the last. Perhaps a standard procedure for this should be added to the SDK?