Skip to content

Rose unmaintained readme#203

Open
beykyle wants to merge 4 commits intodevelopfrom
rose-unmaintained-readme
Open

Rose unmaintained readme#203
beykyle wants to merge 4 commits intodevelopfrom
rose-unmaintained-readme

Conversation

@beykyle
Copy link
Copy Markdown
Contributor

@beykyle beykyle commented Mar 4, 2026

Per discussion yesterday, this PR specifies in the various readmes that rose is no longer maintained.

There is a corresponding PR into the rose repo that adds a statement to the readme there: bandframework/rose#84

If no one on the rose team has a problem with this, I will first merge that, then update the links on this branch to point to the rose repo with this new message. Then this can be pulled in.

I will also add, this is the first time we are "sun-setting" a piece of software, but, given the fact that the nature of our work deals in testing ideas that (despite our best efforts) are not guaranteed to be successful in practice, this likely will not be the last. Perhaps a standard procedure for this should be added to the SDK?

@kylegodbey
Copy link
Copy Markdown
Member

kylegodbey commented Mar 4, 2026

Is the intent to merge this into the dev branch for the upcoming release or should we treat this as a mid-cycle housekeeping task and merge directly into main? Regardless, I think the current PR is merging the current dev branch as well, so I think you want to switch the target branch.

Regarding the text in the README, I think it looks good. We can open an issue regarding the SDK/policy edits for this process moving forward.

@beykyle beykyle changed the base branch from main to develop March 4, 2026 21:47
@beykyle
Copy link
Copy Markdown
Contributor Author

beykyle commented Mar 4, 2026

@kylegodbey Good catch, changed base to develop.

@DanielRPhillips
Copy link
Copy Markdown
Member

I have reviewed the changes. I think this is a good fix to the issue of what to do about the ROSE situation.

I suggest one change to the English: "Also included are packages developed by the the BAND Framework team but are no longer maintained"->either "Also included are packages that were developed by the the BAND Framework team but are no longer maintained:" or "Also included are packages developed by the the BAND Framework team that are no longer maintained:"

We should have a general discussion about whether to change the SDK so it incorporates the possibility of sunsetted software.

@beykyle
Copy link
Copy Markdown
Contributor Author

beykyle commented Mar 11, 2026

Since no one has expressed opposition and Kyle G approves, I'm going to go ahead and merge the PR in rose, and update the links here to point to the main branch of the repo which will reflect the updated readme.

I'll also implement Daniel's suggestion.

@beykyle
Copy link
Copy Markdown
Contributor Author

beykyle commented Mar 11, 2026

It's not clear to me why this test is failing. @wildsm any ideas?

Once that's fixed, this should be good to merge.

Error log from github actions:

Run paramt/url-checker@master
/usr/bin/docker run --name f6157fca5716a845ef406d9d3f8608f083ace3_0964cd --label f6157f --workdir /github/workspace --rm -e "INPUT_FILES" -e "INPUT_BLACKLIST" -e "HOME" -e "GITHUB_JOB" -e "GITHUB_REF" -e "GITHUB_SHA" -e "GITHUB_REPOSITORY" -e "GITHUB_REPOSITORY_OWNER" -e "GITHUB_REPOSITORY_OWNER_ID" -e "GITHUB_RUN_ID" -e "GITHUB_RUN_NUMBER" -e "GITHUB_RETENTION_DAYS" -e "GITHUB_RUN_ATTEMPT" -e "GITHUB_ACTOR_ID" -e "GITHUB_ACTOR" -e "GITHUB_WORKFLOW" -e "GITHUB_HEAD_REF" -e "GITHUB_BASE_REF" -e "GITHUB_EVENT_NAME" -e "GITHUB_SERVER_URL" -e "GITHUB_API_URL" -e "GITHUB_GRAPHQL_URL" -e "GITHUB_REF_NAME" -e "GITHUB_REF_PROTECTED" -e "GITHUB_REF_TYPE" -e "GITHUB_WORKFLOW_REF" -e "GITHUB_WORKFLOW_SHA" -e "GITHUB_REPOSITORY_ID" -e "GITHUB_TRIGGERING_ACTOR" -e "GITHUB_WORKSPACE" -e "GITHUB_ACTION" -e "GITHUB_EVENT_PATH" -e "GITHUB_ACTION_REPOSITORY" -e "GITHUB_ACTION_REF" -e "GITHUB_PATH" -e "GITHUB_ENV" -e "GITHUB_STEP_SUMMARY" -e "GITHUB_STATE" -e "GITHUB_OUTPUT" -e "RUNNER_OS" -e "RUNNER_ARCH" -e "RUNNER_NAME" -e "RUNNER_ENVIRONMENT" -e "RUNNER_TOOL_CACHE" -e "RUNNER_TEMP" -e "RUNNER_WORKSPACE" -e "ACTIONS_RUNTIME_URL" -e "ACTIONS_RUNTIME_TOKEN" -e "ACTIONS_CACHE_URL" -e "ACTIONS_RESULTS_URL" -e "ACTIONS_ORCHESTRATION_ID" -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp":"/github/runner_temp" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/bandframework/bandframework":"/github/workspace" f6157f:ca5716a845ef406d9d3f8608f083ace3
Found file in the locally checked out repo
Removed https://doi.org/10.1088/1361-6471/abf1df
Checking URLs from README.md
Removing duplicate URLs from README.md
✓ 200 https://bandframework.github.io/
✓ 200 https://github.com/beykyle/jitr/releases/tag/v2.5.1
✓ 200 https://github.com/bandframework/surmise/releases/tag/v0.4.0
✓ 200 https://github.com/bandframework/Bfrescox/releases/tag/v0.0.1-alpha
✓ 200 https://bandframework.github.io/
✓ 200 https://github.com/asemposki/neutron-rich-bmm/releases/tag/v0.1.0
✓ 200 https://github.com/parmoo/parmoo/releases/tag/v0.4.1
✓ 200 https://github.com/ascsn/pybmc/releases/tag/v0.2.4
✓ 200 https://github.com/parallelUQ/PUQ/releases/tag/v0.1.1
✓ 200 https://github.com/bandframework/rose/tree/main
✓ 200 https://github.com/sjaiswal-tifr/ModelDiscrepancy/releases/tag/v1.1.0
✓ 200 https://github.com/cdrischler/nuclear_saturation/tree/c4cfa45a1180b2739e217102d7380736d6844a11
✓ 200 https://github.com/danOSU/QGP_Bayes/tree/4b3e2364f87a29ad2469f2b072053420fdaac8e9
✓ 200 https://github.com/bandframework/Taweret/releases/tag/v1.2.0
✓ 200 https://github.com/asemposki/SAMBA/releases/tag/v1.2.1
✓ 200 https://github.com/mosesyhc/lcgp/releases/tag/v0.2.1
✓ 200 https://github.com/bandframework/bandframework
✓ 200 https://github.com/massexplorer/bmex-masses/releases/tag/v0.1.4

Found file in the locally checked out repo
Checking URLs from software/README.md
Removing duplicate URLs from software/README.md

Found file in the locally checked out repo
Checking URLs from resources/README.md
Removing duplicate URLs from resources/README.md

Found file in the locally checked out repo
Removed bandsdk.md
Removed template.md
Removed BMEX-bandsdk.md
Removed brickbandsdk.md
Removed bfrescoxbandsdk.md
Removed frescoxbandsdk.md
Removed jitrbandsdk.md
Removed lcgp-bandsdk.md
Removed MD-bandsdk.md
Removed nsat-bandsdk.md
Removed parmoo-bandsdk.md
Removed PUQ-bandsdk.md
Removed pybmc-bandsdk.md
Removed rosebandsdk.md
Removed SAMBAbandsdk.md
Removed SmoothEmulatorSDK.md
Removed surmisebandsdk.md
Removed Taweretbandsdk.md
Checking URLs from resources/sdkpolicies/README.md
Removing duplicate URLs from resources/sdkpolicies/README.md
✕ 429 https://github.com/sjaiswal-tifr/ModelDiscrepancy/blob/main/MD-bandsdk.md
✕ 429 https://github.com/bandframework/Bfrescox/blob/main/Bfrescoxbandsdk.md
✕ 429 https://github.com/danOSU/QGP_Bayes/blob/main/QGP_Bayesbandsdk.md
✕ 429 https://github.com/cdrischler/nuclear_saturation/blob/main/nsat-bandsdk.md
✕ 429 https://github.com/mosesyhc/LCGP/blob/main/lcgp-bandsdk.md
✕ 429 https://github.com/asemposki/neutron-rich-bmm/blob/main/neutron-rich-bmm_bandsdk.md
✕ 429 https://github.com/beykyle/jitr/blob/main/jitrbandsdk.md
✕ 429 https://github.com/bandframework/Taweret/blob/main/Taweretbandsdk.md
✕ 429 https://github.com/bandframework/surmise/blob/main/surmisebandsdk.md
✕ 429 https://github.com/bandframework/rose/blob/main/rosebandsdk.md
✕ 429 https://github.com/asemposki/SAMBA/blob/main/SAMBAbandsdk.md

Found file in the locally checked out repo
Removed foobandsdk.md
Checking URLs from resources/sdkpolicies/bandsdk.md
Removing duplicate URLs from resources/sdkpolicies/bandsdk.md
✓ 200 https://bandframework.github.io/team
✓ 200 https://github.com/bandframework/bandframework

Found file in the locally checked out repo
Removed foobandsdk.md
Checking URLs from resources/sdkpolicies/template.md
Removing duplicate URLs from resources/sdkpolicies/template.md
✓ 200 https://bandframework.github.io/team
✓ 200 https://github.com/bandframework/bandframework

Found file in the locally checked out repo
Checking URLs from resources/dev_guide/git_instructions_for_submodules.md
Removing duplicate URLs from resources/dev_guide/git_instructions_for_submodules.md
✓ 200 https://github.com/marketplace/actions/github-repo-stats
✓ 200 https://github.com/bandframework/bandframework/
✓ 200 https://github.com/bandframework/bandframework/tree/develop
✓ 200 https://github.com/bandframework/bandframework/pulls
✓ 200 https://github.com/jgehrcke/github-repo-stats/wiki/Tutorial

Found file in the locally checked out repo
Checking URLs from examples/README.md
Removing duplicate URLs from examples/README.md

Found file in the locally checked out repo
Checking URLs from BANDsoftware_uses/README.md
Removing duplicate URLs from BANDsoftware_uses/README.md

@jared321
Copy link
Copy Markdown
Contributor

The action is failing due to failures to follow certain links such as

✕ 429 https://github.com/sjaiswal-tifr/ModelDiscrepancy/blob/main/MD-bandsdk.md

I believe that 429 refers to the error code returned by the link's host, which would appear to indicate a "Too Many Requests" failure. This would be consistent with the fact that the above link can be successfully followed otherwise.

However, rerunning the action resulted in the same failure. Investigating.

@jared321 jared321 mentioned this pull request Mar 16, 2026
@jared321
Copy link
Copy Markdown
Contributor

The action failure and a possible solution are being documented in Issue #205.

Fix broken URL checker action
@jared321
Copy link
Copy Markdown
Contributor

Action failure is now fixed in this branch and actions are passing again. I'll review soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants