Skip to content

Switch URL Checker#206

Merged
jared321 merged 11 commits intomainfrom
205Lychee
Apr 1, 2026
Merged

Switch URL Checker#206
jared321 merged 11 commits intomainfrom
205Lychee

Conversation

@jared321
Copy link
Copy Markdown
Contributor

@jared321 jared321 commented Mar 20, 2026

PR Self-review

  • Review all changes made in branch
  • Check altered azure links through rendered docs
  • Check altered PUQ link through rendered doc
  • Check altered parmoo link through rendered doc
  • Review log of new action to confirm correctness and suitability
    • Exclusions were entered manually by me or are reasonable
    • Clicked links in logs for manually excluded links and confirmed that they go where expected
  • Confirm all actions passing

Note that this tool is reporting that it is skipping the verification of several email addresses. While this seems OK, lychee should be checking email addresses by default.

This initial setup was derived from some preliminary testing of the tool in a
throwaway repo containing some of the content in this repo.  Based on that
experience, we should expect multiple failures.
@jared321 jared321 self-assigned this Mar 20, 2026
The azure link is to a registration page that contains editable fields, which
might cause access failures.  Tried changing it to just the landing page.  Users
should still be able to determine how to register to access software from that
page.
Stefan has said that there will be a PR into develop for parmoo soon to account
for a recent refactoring.  This is a temporary fix to get the URL checker action
passing.  Ideally, this change will be in develop before they base their branch
off of it and can adjust the text as needed.
Two were written with http instead of https.  Lychees was ignoring these with
the statement that they are unsupported.  This will get rid of those statements
and makes the links like the first azure link that I dealt with.  Ultimately,
they will be ignored.
It is using an old version of actions that rely on Node.js 20, which will be
dropped soon.  Might as well fix this with the URL checker as a single
infrastructure hot fix.
Copy link
Copy Markdown
Member

@DanielRPhillips DanielRPhillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked all the revised links in the new branch and all now go to the right place. Actions are passing.

@jared321 jared321 merged commit 93f4d2b into main Apr 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants