Conversation
Also moving Variant<T>::Which to VariantWhich<T>, which is necessary to create is_variant_which.
3678158 to
0ee2656
Compare
arBmind
requested changes
Feb 4, 2020
Member
arBmind
left a comment
There was a problem hiding this comment.
Good stuff but the usage becomes a bit too strange and repetitive.
I would be more than happy to pull this if you find time to fix my annotations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also moving Variant::Which to VariantWhich, which is necessary to create is_variant_which.