Merged
Conversation
Expand the Overview. Add more context on core rules vs packaging rules and level of support. Add instructions for using Bazel Federation. Move pip stuff to sub-headings.
Contributor
Author
|
Setting Tony as reviewer, but I'm going to force submit in the interest of getting a release out tonight since I'm OOO tomorrow. Feel free to leave me comments to forward-fix afterwards. |
Contributor
Author
|
It looks kind of strange that the WORKSPACE boilerplate produced by the //distro:relnotes target doesn't mention the federation at all. Is that because it's expected that |
brandjon
added a commit
to brandjon/rules_python
that referenced
this pull request
Oct 10, 2019
Follow-up to bazel-contrib#237. Moves development workflow info to CONTRIBUTING.md. Fixes the instructions for how to use the Bazel Federation. Also updates the project WORKSPACE to use a released version of the Federation.
Merged
Contributor
Author
|
See #239 for post-merge fixes. |
brandjon
added a commit
that referenced
this pull request
Oct 18, 2019
Follow-up to #237. Moves development workflow info to CONTRIBUTING.md. Fixes the instructions for how to use the Bazel Federation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand the Overview. Add more context on core rules vs packaging rules and
level of support. Add instructions for using Bazel Federation. Move pip stuff
to sub-headings.
Fixes #229.