Skip to content
This repository was archived by the owner on Mar 8, 2020. It is now read-only.

Drop all comments for BlockStatement#68

Merged
bzz merged 1 commit intobblfsh:masterfrom
bzz:fix-block-comments
Mar 15, 2019
Merged

Drop all comments for BlockStatement#68
bzz merged 1 commit intobblfsh:masterfrom
bzz:fix-block-comments

Conversation

@bzz
Copy link
Copy Markdown
Contributor

@bzz bzz commented Mar 13, 2019

Part of the SDK update: new case of comments for block statement which right now results in

transform failed: received 2 errors:
	check: unused field(s) on node BlockStatement: [innerComments leadingComments]
	check: unused field(s) on node BlockStatement: leadingComments

@bzz bzz added the bug label Mar 13, 2019
@bzz bzz added this to the v2.7.0 milestone Mar 13, 2019
@bzz bzz self-assigned this Mar 13, 2019
@bzz bzz requested review from dennwc and juanjux March 13, 2019 18:26
@bzz bzz mentioned this pull request Mar 13, 2019
Closed
@bzz bzz force-pushed the fix-block-comments branch from d87b00c to 19058d9 Compare March 13, 2019 18:33
@bzz bzz merged commit 7a2e9d1 into bblfsh:master Mar 15, 2019
@bzz bzz deleted the fix-block-comments branch March 15, 2019 11:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@juanjux juanjux Awaiting requested review from juanjux

1 more reviewer

@dennwc dennwc dennwc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bzz bzz

Labels

bug

Projects

None yet

Milestone

v2.7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@bzz @dennwc