This repository was archived by the owner on Mar 8, 2020. It is now read-only.
Derive the libuast os/arch selector from sys.platform.#157
Merged
creachadair merged 2 commits intobblfsh:masterfrom May 3, 2019
creachadair:ambience
Merged
Derive the libuast os/arch selector from sys.platform.#157creachadair merged 2 commits intobblfsh:masterfrom creachadair:ambience
creachadair merged 2 commits intobblfsh:masterfrom
creachadair:ambience
Conversation
dennwc
approved these changes
May 2, 2019
Part of the pyuast build process fetches a binary release of libuast. Previously, the release version was pinned to linux-amd64. This change makes it consult sys.platform. Unfortunately, sys.platform doesn't exactly match the release tag for windows, but since we only have binary releases for Linux, Darwin, and Windows anyway, it is a straightforward patch. The default remains linux-amd64 in case someone has another platform; if it was wrong before it will still be wrong, but in the same way. Signed-off-by: M. J. Fromberger <[email protected]>
Part of the fix for #156. Signed-off-by: M. J. Fromberger <[email protected]>
dennwc
approved these changes
May 2, 2019
bzz
approved these changes
May 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the fix for #156.
Part of the
pyuastbuild process fetches a binary release oflibuast. Previously, the release version was pinned tolinux-amd64, and therefore did not link correctly on macOS (Darwin).This change makes the build script consult
sys.platform. The default remainslinux-amd64in case someone has another platform; if it was wrong before it will still be wrong, but in the same way.