This repository was archived by the owner on Mar 8, 2020. It is now read-only.
Fix/more simpleidentifier#23
Merged
smola merged 2 commits intobblfsh:masterfrom Jun 15, 2017
juanjux:fix/more_simpleidentifier
Merged
Fix/more simpleidentifier#23smola merged 2 commits intobblfsh:masterfrom juanjux:fix/more_simpleidentifier
smola merged 2 commits intobblfsh:masterfrom
juanjux:fix/more_simpleidentifier
Conversation
abeaumont
approved these changes
Jun 14, 2017
smola
approved these changes
Jun 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a wrong concept of the SimpleIdentifier role, this PR fixes it adding it to some nodes that should also have it like FunctionDef and CallCalee.