This repository was archived by the owner on Mar 8, 2020. It is now read-only.
Catches exceptions in decode native method#131
Merged
ncordon merged 1 commit intobblfsh:masterfrom Sep 18, 2019
Merged
Conversation
Signed-off-by: ncordon <[email protected]>
kuba--
reviewed
Sep 12, 2019
kuba--
approved these changes
Sep 12, 2019
creachadair
approved these changes
Sep 18, 2019
Contributor
creachadair
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kuba--)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catches the exception in the decode native method when the bytes we pass to the function cannot be decoded by
libuast. This PR mirrors the changes introduced by python-client#190.Closes #130
Signed-off-by: ncordon [email protected]
This change is