Skip to content

fix(scale): bound unpack arguments count#297

Merged
skeggse merged 3 commits intobee-queue:masterfrom
chromaui:unpack-in-batches
Nov 4, 2020
Merged

fix(scale): bound unpack arguments count#297
skeggse merged 3 commits intobee-queue:masterfrom
chromaui:unpack-in-batches

Conversation

@tmeasday
Copy link
Copy Markdown
Contributor

@tmeasday tmeasday commented Oct 23, 2020

If there are many many stalled jobs, we can hit lua's built in stack limit when trying to unpack them all in the checkStalledJobs script. This does the unpacking in batches.

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 23, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling e9871fd on chromaui:unpack-in-batches into 16b02a9 on bee-queue:master.

1 similar comment
@coveralls
Copy link
Copy Markdown

coveralls commented Oct 23, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling e9871fd on chromaui:unpack-in-batches into 16b02a9 on bee-queue:master.

skeggse
skeggse reviewed Oct 28, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@skeggse skeggse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Couple small tweaks, please :)

@skeggse skeggse added awaiting-reply Issues that need more information. bug labels Oct 28, 2020
@tmeasday
Copy link
Copy Markdown
Contributor Author

tmeasday commented Oct 30, 2020

@skeggse do you have any idea why linting started failing (for README.md on only two environments) when I commited your simple lua changes? (It seems like lua isn't linted anyway...?)

@tmeasday
Copy link
Copy Markdown
Contributor Author

tmeasday commented Oct 30, 2020

Oh, I see there is a broken build on master. I think this is ready for review then (tests partially passing!)

@tmeasday tmeasday requested a review from skeggse October 30, 2020 05:28
@skeggse
Copy link
Copy Markdown
Member

skeggse commented Oct 30, 2020

Oh, I see there is a broken build on master. I think this is ready for review then (tests partially passing!)

Fixed now - please rebase!

@tmeasday
Copy link
Copy Markdown
Contributor Author

tmeasday commented Nov 4, 2020

Done.

@skeggse skeggse added this to the 1.3.1 milestone Nov 4, 2020
@skeggse skeggse self-assigned this Nov 4, 2020
@skeggse skeggse removed the awaiting-reply Issues that need more information. label Nov 4, 2020
@skeggse skeggse merged commit 4108e5e into bee-queue:master Nov 4, 2020
beequeueci pushed a commit that referenced this pull request Nov 4, 2020
@semantic-release-bot
chore(release): 1.3.1 [skip ci]
0682e62 
### [1.3.1](v1.3.0...v1.3.1) (2020-11-04)

### Bug Fixes

* **scale:** bound unpack arguments count ([#297](#297)) ([4108e5e](4108e5e))
* **types:** fix typescript definitions errors ([#311](#311)) ([3bc3f31](3bc3f31))
@beequeueci
Copy link
Copy Markdown
Collaborator

beequeueci commented Nov 4, 2020

🎉 This PR is included in version 1.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@skeggse skeggse changed the title Ensure we don't call unpack with too many elements fix(scale): bound unpack arguments count Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skeggse skeggse skeggse approved these changes

Assignees

@skeggse skeggse

Labels

bug released

Projects

None yet

Milestone

1.3.1

Development

Successfully merging this pull request may close these issues.

4 participants

@tmeasday @coveralls @skeggse @beequeueci