fixed show-timing work when no tty attached#1165
Open
fedusia wants to merge 1 commit intobehave:mainfrom
Open
Conversation
0a4d73b to
2c11d2e
Compare
3e51dda to
c6ab01c
Compare
eccf022 to
93e1218
Compare
cc16ac0 to
22569f4
Compare
01407cf to
42e64a9
Compare
9dc617b to
b8b23bc
Compare
612d6d1 to
5796057
Compare
6971c4c to
b1470c0
Compare
370ce68 to
cba3c4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default behave uses pretty formatter, it can write in 2 stream types - tty or simple character device, for example simple file or pipe.
Common logic of processing steps described here
If stream is tty character device. Firstly it prints step during matching phase (just only parsed step from feature file without additional data), then step executes and writes additional data like step status, duration and then it rewrites last line in terminal with latest data.
If steam is NOT tty (file or pipe). It prints step information only during matching phase and doesn't rewrite it during execution phase.
This PR should change behavior.
If stream is not tty character device then print step information skips during match phase and prints after execution phase.