fix: Configuration argument verbose unused#1264
fix: Configuration argument verbose unused#1264satelliteprogrammer wants to merge 1 commit intobehave:mainfrom
verbose unused#1264Conversation
Configuration is not applying the verbose it receives as argument. The issue is that the `init` method receives `verbose` as a separate argument from all others and is not passing it to `make_default`. The defaults are then passed to the `ArgumentParser`, which would be missing the verbose initially passed to `Configuration`, and where verbose has action="proxy.php?url=https%3A%2F%2Fgithub.com%2Fstore_true", making it default to False. This patch also stores `verbose` in the defaults used by the arg parser.
|
Hi. I checked the tests, but the |
|
I a not quite sure what your problem exactly is (except that I think you are mistaken).
|
|
Hi @jenisys, The issue is when instantiating a The following would not enable verbose mode. despite verbose being in the If verbose is explicitly offered as an argument my expectation is that setting it to True would enable verbose logging. |
|
I will think about it. config = Configuration([“—verbose“])
assert config.verbose is True
assert run_behave(config) == os.EX_OK |
|
And that's probably what we will use for now. options = {
"junit": True,
"load_config": False,
# ...
"verbose": True,
}
config = Configuration([], tags=tags, paths=[tests_path()], stage="", **options) |
370ce68 to
cba3c4f
Compare
Configuration is not applying the verbose it receives as argument.
The issue is that the
initmethod receivesverboseas a separateargument from all others and is not passing it to
make_default. Thedefaults are then passed to the
ArgumentParser, which would be missingthe verbose initially passed to
Configuration, and where verbose hasaction="proxy.php?url=https%3A%2F%2Fgithub.com%2Fstore_true", making it default to False.
This patch also stores
verbosein the defaults used by the arg parser.