Open
Conversation
bittner
requested changes
Feb 23, 2026
| from enum import Enum | ||
|
|
||
|
|
||
| def reraise(tp, value, tb=None): |
Member
There was a problem hiding this comment.
Can you add a docstring explaining the motivation for this function?
It's not clear why "re-raise" wouldn't simply be a simple raise (with not arguments).
Contributor
Author
There was a problem hiding this comment.
This is the snippet taken verbatim from six.py
Yes it could be simpler ... I m not sure if raise is enough.
That's why I does this PR last
Member
There was a problem hiding this comment.
I understand you've taken it from six, but we should explain its existence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I vendored 1 tiny function