Skip to content

finish removal of "six"#1309

Open
a-detiste wants to merge 1 commit intobehave:mainfrom
a-detiste:main
Open

finish removal of "six"#1309
a-detiste wants to merge 1 commit intobehave:mainfrom
a-detiste:main

Conversation

@a-detiste
Copy link
Copy Markdown
Contributor

I vendored 1 tiny function

Comment thread behave/runner.py
from enum import Enum


def reraise(tp, value, tb=None):
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a docstring explaining the motivation for this function?

It's not clear why "re-raise" wouldn't simply be a simple raise (with not arguments).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the snippet taken verbatim from six.py

Yes it could be simpler ... I m not sure if raise is enough.

That's why I does this PR last

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand you've taken it from six, but we should explain its existence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants