Fix: ResourceWarning on python 3.12 and remove deprecated usage of codecs#1314
Merged
bittner merged 2 commits intobehave:mainfrom Apr 16, 2026
Merged
Fix: ResourceWarning on python 3.12 and remove deprecated usage of codecs#1314bittner merged 2 commits intobehave:mainfrom
bittner merged 2 commits intobehave:mainfrom
Conversation
3 tasks
There was a problem hiding this comment.
Pull request overview
Fixes a Python 3.12+ ResourceWarning (and Python 3.14 deprecation risk) in JUnitReporter.feature() by ensuring the JUnit XML output file is properly closed and by removing deprecated codecs.open() usage.
Changes:
- Remove the unused/deprecated
codecsimport. - Write JUnit XML using a
with open(..., "wb")context manager to ensure deterministic file closure.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Verifies that JUnitReporter.feature() deterministically closes the report file handle (no ResourceWarning) and writes valid XML output. This test was added for PR behave#1314.
Member
|
Thank you and your agent! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JUnitReporter.feature() opens the XML output file with codecs.open() but never
closes it. This causes a ResourceWarning on Python 3.12+ and will break on Python 3.14,
where codecs.open() is deprecated.
This PR fixes both issues with a one-line change.
Issue