Open
Conversation
kelichiu
approved these changes
Mar 2, 2025
kelichiu
left a comment
There was a problem hiding this comment.
Complete
Code Execution
All code cells execute without errors.
Code Quality
Code is well-organized, concise, and includes necessary comments for clarity.
Data Handling
Data files are correctly handled and processed.
Adherence to Instructions
Follows all instructions and requirements as per the assignment.
Specific Criteria
- Reading in our files
Correctly prints out information from the first file. - Summarizing our data
Correctly defines patient_summary() function. Function processes data as per operation and outputs correctly shaped data (60 entries). - Checking for Errors
Correctly defines detect_problems() function. Function uses patient_summary() and check_zeros() to identify mean inflammation of 0 accurately.
Overall Assessment
Meets all the general and specific criteria, indicating a strong understanding of the assignment objectives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I added few lines of new codes as well as updated the existing codes wherever needed to run the requests as asked.
What did you learn from the changes you have made?
There were logical steps in creating the functions. I had to make sure the order of the steps was appropriate, so I could use a predefined function within another function.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
NA
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Yes, change the paths in the first step was challenging. In order to do so, I changed the home directory and appended the home directory to all_paths to make them as full_paths. This step is to ensure it would be able to access the data files correctly.
How were these changes tested?
Tested in Visual Studio to see if the return results were as expected or not.
A reference to a related issue in your repository (if applicable)
NA
Checklist