Open
Conversation
niyazmnazari
approved these changes
Jan 26, 2025
niyazmnazari
left a comment
There was a problem hiding this comment.
Thank you for submitting Assignment 1. Everything looks correct. Great job!
Point: 30/30
P.S. Just a quick note, you don't need to use single quote when comparing integers. For example:
SELECT * FROM product WHERE product_id=4
Single quote used when we want to use string and character:
SELECT * FROM customer WHERE customer_first_name = 'Sofia'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Create a logical-relationship diagram between customer table and customer purchases table
Complete coding questions in sql file
Complete section 4 in markdown file
What did you learn from the changes you have made?
I learned a lot from reading "When Databases Get to Define Family". I hadn’t previously thought about how database design can reinforce and has reinforced social hierarchies and inequalities around the world.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I was considering making the query output more comprehensive or cleaner. For example, in the second question of the aggregate section, I debated whether to show the actual amount of money that everyone spent at the market or to calculate it quietly within the HAVING statement. I think both approaches have their pros and cons, and the choice is very question- and context-driven.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
The codes were relatively straightforward. I was able to compare the results from the output and manual calculation from the 'Browse Data' tab to verify the results.
How were these changes tested?
Run sql codes in DB Browser
Check changes using git status, commit the change, and then push the change
A reference to a related issue in your repository (if applicable)
Checklist