Use prediction_domain for all prediction methods#284
Closed
cheesinglee wants to merge 1 commit intobigmlcom:masterfrom
Closed
Use prediction_domain for all prediction methods#284cheesinglee wants to merge 1 commit intobigmlcom:masterfrom
cheesinglee wants to merge 1 commit intobigmlcom:masterfrom
Conversation
mmerce
reviewed
Nov 19, 2019
|
|
||
| """ | ||
| self.batch_prediction_url = self.url + BATCH_PREDICTION_PATH | ||
| self.batch_prediction_url = (self.prediction_base_url + |
Member
There was a problem hiding this comment.
I don't think the predict server does batch predictions... does it? @sdesimone ?
|
@mmerce: yes, it does
… On 19 Nov 2019, at 22:45, mmerce ***@***.***> wrote:
@mmerce commented on this pull request.
In bigml/batchpredictionhandler.py <#284 (comment)>:
> @@ -46,7 +46,8 @@ def __init__(self):
instantiated independently.
"""
- self.batch_prediction_url = self.url + BATCH_PREDICTION_PATH
+ self.batch_prediction_url = (self.prediction_base_url +
I don't think the predict server does batch predictions... does it? @sdesimone <https://github.com/sdesimone> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#284?email_source=notifications&email_token=AAG75CYO52RP3MGEMBOCQI3QURM7HA5CNFSM4JOACJ32YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCMEUOZY#pullrequestreview-319375207>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAG75C22ZLAV5PDHSW37ZLLQURM7HANCNFSM4JOACJ3Q>.
|
Member
|
Oh, and only batch predictions? no batch anomaly scores, bathc centroids...? |
|
It should do all of them (bugs apart)
… On 19 Nov 2019, at 22:49, mmerce ***@***.***> wrote:
Oh, and only batch predictions? no batch anomaly scores, bathc centroids...?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#284?email_source=notifications&email_token=AAG75CZVUXZHSWAQ73TIOKTQURNPRA5CNFSM4JOACJ32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEP4UKI#issuecomment-555731497>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAG75C6P7RWIUAWWWUEDHXLQURNPRANCNFSM4JOACJ3Q>.
|
Member
|
Great, so we should change them too to be able to use this prediction_base_url too |
Member
|
I'm closing the PR and adding it to #285 @cheesinglee |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when the api is instantiated with a value for
prediction_domain, that value is only used for calls tocreate_prediction, and not other prediction-like methods such ascreate_batch_prediction,create_centroid,create_anomaly_score, etc.This PR changes the handlers for those methods to use the value for
prediction_domain.