Merged
Conversation
This change can fix binareio#15. However, it also introduces the possibility for unvalidated reference urls. So if there are other applications pulling data from the API, it may happen that untrusted data is returned. However, according to OWASP, one should never trust data from remote origins. So other applications relying on fastcve should execute their own validations too.
Owner
|
I agree with the proposed change, and it will also unify how command-line and API search results handle invalid URLs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change can fix #15.
However, it also introduces the possibility for unvalidated reference urls. So if there are other applications pulling data from the API, it may happen that untrusted data is returned.
However, according to OWASP, one should never trust data from remote origins. So other applications relying on fastcve should execute their own validations too.