Merged
Conversation
binareio
reviewed
Mar 12, 2024
Owner
binareio
left a comment
There was a problem hiding this comment.
The alembic script for DB update for the added new table is missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are several enhancements for the current modifications to the EPSS system. Originally, the requirements did not account for the presence of epss scores for nearly all CVEs. Furthermore, updating the entire Vuln table with epss data is impractical. Thus, it's necessary to establish a distinct table dedicated to storing epss data. Subsequently, we should adjust the
save_epss_datamethod to store the data in the Epss table. Additionally, a new method,fetch_epss_data, should be created to update the Vuln table with the latest epss information. Finally,fetch_epss_datashould be integrated into thesave_cve_datamethod for seamless functionality.