Add schnorr-musig-frost-and-more review to chaincode-labs/chaincode-podcast#524
Conversation
- multisigs - N-of-N
kouloumos
left a comment
There was a problem hiding this comment.
Thank you for your contribution, @sagungargs15! This is an excellent first submission, and I truly appreciate the effort you put into fixing the AI transcription errors. The extra steps you took to add links and chapters are also highly valued.
I noticed you added backticks around several technical terms, which shows attention to detail. However, we currently only use backticks for Opcodes and math equations, so we’ll need to remove all of the backticks that you added. You can easily do this with a find-and-replace. We're in the process of refining our guidelines on this to avoid confusion in the future.
I’ve also left a few inline comments with some minor changes. As an example, I’ve made a commit with revisions regarding multisig notation for you to reference.
Once you’ve made these adjustments, we’ll be all set to merge your contribution. Thanks again for your hard work—you're off to a great start!
Based on recommendations by @kouloumos I made a revised commit on top of "commit with revisions regarding multisig notation"
Fixed remaining changes
|
@kouloumos Thanks for your insights and effort. It helped me understand the review process better. All done and resolved. Please help review when possible. Excited to pickup next one :) |
we still haven't decide how to treat the hosts of the podcast, do we add them to the speakers or not? for now we don't add them, but we can always come back and do it.
|
I pushed a couple of minor fixups and this is now ready to merge! 🚀 Thank you @sagungargs15! Hopefully we will see more transcripts from you in the future! |
This PR adds schnorr-musig-frost-and-more transcript review to the chaincode-labs/chaincode-podcast directory.